Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10012

PropertySet.combine() should take const& PropertySet not std::shared_ptr<const PropertySet>

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: daf_base
    • Labels:
      None

      Description

      It is not currently possible to merge PropertySets unless you happen to have a shared pointer.

      PropertySet.combine() should take const& PropertySet not std::shared_ptr<const PropertySet>

        Attachments

          Activity

          Hide
          rowen Russell Owen added a comment -

          There are a many other functions that take a shared pointer to a PropertySet or PropertyList when a const reference would do. Could we please expand this ticket to fix most of them, not just this one instance?

          Show
          rowen Russell Owen added a comment - There are a many other functions that take a shared pointer to a PropertySet or PropertyList when a const reference would do. Could we please expand this ticket to fix most of them, not just this one instance?
          Hide
          jbosch Jim Bosch added a comment -

          I'm calling this Won't Fix because we've got many worse C++ interface inconveniences we'll probably never get to, as we've shifted as much development as possible to Python.

          Show
          jbosch Jim Bosch added a comment - I'm calling this Won't Fix because we've got many worse C++ interface inconveniences we'll probably never get to, as we've shifted as much development as possible to Python.

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            rhl Robert Lupton
            Watchers:
            Jim Bosch, Robert Lupton, Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.