Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10033

qserv_areaspec_ellipse incorrectly uses semi-major/minor axis parameters

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
    • Templates:
    • Story Points:
      4
    • Sprint:
      DB_F19_07
    • Team:
      Data Access and Database

      Description

      qserv_areaspec_ellipse has semi-major and semi-minor axis parameters. These were documented to be in arcsec, but the code appears to instantiate a sphgeom::Ellipse assuming the values are in degrees. I have just changed the documentation to correspond to this, but I think that is actually wrong, because the scisql UDF that is added to the WHERE clause requires those parameters to be in arcsec.

      So I think the correct fix is to change the documentation back to arcsec and have the sphgeom::Ellipse constructed using arcsec rather than degrees.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                npease Nate Pease
                Reporter:
                ktl Kian-Tat Lim
                Reviewers:
                Andy Salnikov
                Watchers:
                Andy Salnikov, Christine Banek, Colin Slater, David Shupe, Fritz Mueller, Gregory Dubois-Felsmann, Kenny Lo, Kian-Tat Lim, Nate Pease, Tatiana Goldina
              • Votes:
                0 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel