Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10045

Make a plan for updates to & maintenance of QA plotting scripts

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      5
    • Epic Link:
    • Sprint:
      DRP S17-6
    • Team:
      Data Release Production

      Description

      Having demonstrated (in DM-10044) that the QA plotting scripts work, make a plan for how we need to maintain and upgrade them. In particular:

      • Make sure they follow the regular LSST coding conventions;
      • Make sure they are committed to the master branch of some repository;
      • Remove any HSC-specific code;
      • Refactor/update/revise etc as necessary to make them suitably idiomatic.

      (NB this ticket really is "make a plan" not "do all the above work" — I'd imagine you might spawn one or more tickets for the various upgrades needed).

      In the process, consult with the SQuaRE group (probably Michael Wood-Vasey is the first point of contact) to see how the scripts can be most conveniently made useful to the rest of the project — consider e.g. integration with SQuaSH or similar.

        Attachments

        1. extractStats.py
          3 kB
        2. harvest.py
          13 kB
        3. plotStats.py
          7 kB

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-10044 Produce QA plots

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-4880 Test capabilities of python bokeh plotting library for making interactive plots - I

          • Done

            Activity

            Ascending order - Click to sort in descending order
            4 older comments
            Hide
            Permalink
            tmorton Tim Morton [X] (Inactive) added a comment -

            Yeah, sounds good. Yeah, the version on github is quite different from yours---i had to manually apply your previous changes in the appropriate places when I ported over your previous improvements, and I can do this again.

            Paul Price if you're going to be doing a lot more of these optimizations, perhaps it would be worth it to update your repo to match what is shared on github? I think all the API is the same, just reorganized?

            Show
            tmorton Tim Morton [X] (Inactive) added a comment - Yeah, sounds good. Yeah, the version on github is quite different from yours---i had to manually apply your previous changes in the appropriate places when I ported over your previous improvements, and I can do this again. Paul Price if you're going to be doing a lot more of these optimizations, perhaps it would be worth it to update your repo to match what is shared on github? I think all the API is the same, just reorganized?
            Hide
            Permalink
            tmorton Tim Morton [X] (Inactive) added a comment -

            I have created a page on Confluence outlining the plan for QA-plot upgrades:

            https://confluence.lsstcorp.org/display/DM/Development+plans+for+pipe_analysis

            Show
            tmorton Tim Morton [X] (Inactive) added a comment - I have created a page on Confluence outlining the plan for QA-plot upgrades: https://confluence.lsstcorp.org/display/DM/Development+plans+for+pipe_analysis
            Hide
            Permalink
            tmorton Tim Morton [X] (Inactive) added a comment -

            Robert Lupton let me know if you think this plan is along the track you were imagining/hoping for.

            Show
            tmorton Tim Morton [X] (Inactive) added a comment - Robert Lupton let me know if you think this plan is along the track you were imagining/hoping for.
            Hide
            Permalink
            tmorton Tim Morton [X] (Inactive) added a comment -

            Btw, SQuaRE folks seem to already be using Bokeh, so this seems like a good direction such that final implementation may have not too much friction; or that so the prototype may actually turn out to be somewhat useful in the end if we want to integrate with SQuaSH.

            Show
            tmorton Tim Morton [X] (Inactive) added a comment - Btw, SQuaRE folks seem to already be using Bokeh, so this seems like a good direction such that final implementation may have not too much friction; or that so the prototype may actually turn out to be somewhat useful in the end if we want to integrate with SQuaSH.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            We discussed this plan at our meeting of 2017-06-07; Robert Lupton is happy for this work to go ahead in F17.

            Show
            swinbank John Swinbank added a comment - We discussed this plan at our meeting of 2017-06-07; Robert Lupton is happy for this work to go ahead in F17.

              People

              Assignee:
              tmorton Tim Morton [X] (Inactive)
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Robert Lupton
              Watchers:
              Angelo Fausti, Frossie Economou, John Swinbank, Lauren MacArthur, Paul Price, Robert Lupton, Tim Morton [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.