Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1005

Migrate Qserv worker code to the new logging system

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None
    • Story Points:
      8
    • Epic Link:
    • Sprint:
      DB_S14_08, DB_S14_9
    • Team:
      Data Access and Database

      Attachments

        Issue Links

          Activity

          Hide
          salnikov Andy Salnikov added a comment -

          (why does not JIRA have "Reply to" option?)

          Jacek wrote:

          Andy please note that I moved log.git from contrib/ to lsst/DMS/ so you will need to re-clone it

          Should we get rid of contrib/log.git repo to avoid possible confusion?

          Show
          salnikov Andy Salnikov added a comment - (why does not JIRA have "Reply to" option?) Jacek wrote: Andy please note that I moved log.git from contrib/ to lsst/DMS/ so you will need to re-clone it Should we get rid of contrib/log.git repo to avoid possible confusion?
          Hide
          ktl Kian-Tat Lim added a comment -

          contrib/log.git was removed (well, actually just moved) when Jacek made it into LSST/DMS/log.git. Unfortunately, the first attempt to access contrib/log.git by someone that had it cloned caused gitolite to re-create the repository. This is not really worth fixing in gitolite, but trashing the resulting empty repository should indeed be done.

          Show
          ktl Kian-Tat Lim added a comment - contrib/log.git was removed (well, actually just moved) when Jacek made it into LSST/DMS/log.git . Unfortunately, the first attempt to access contrib/log.git by someone that had it cloned caused gitolite to re-create the repository. This is not really worth fixing in gitolite , but trashing the resulting empty repository should indeed be done.
          Hide
          ktl Kian-Tat Lim added a comment -

          (Oh, of course that trashing should occur after everyone has moved to the new remote, or else we'll just get it re-created accidentally again.)

          Show
          ktl Kian-Tat Lim added a comment - (Oh, of course that trashing should occur after everyone has moved to the new remote, or else we'll just get it re-created accidentally again.)
          Hide
          danielw Daniel Wang [X] (Inactive) added a comment -

          I looked at

           admin/templates/server/etc/init.d/xrootd         |   1 +
           admin/templates/server/etc/log4xrootd.properties |   8 ++
           core/modules/SConscript                          |  12 +--
           core/modules/xrdfs/MySqlFs.cc                    |  43 ++++----
           core/modules/xrdfs/MySqlFs.h                     |  10 +-
           core/modules/xrdfs/MySqlFsDirectory.cc           |   6 +-
           core/modules/xrdfs/MySqlFsDirectory.h            |  13 ++-
           core/modules/xrdfs/MySqlFsFile.cc                |  89 ++++++++---------
           core/modules/xrdfs/MySqlFsFile.h                 |   5 +-
           core/modules/xrdfs/SConscript.test               |   2 +-
           core/modules/xrdfs/XrdLogger.h                   |  53 ----------
           core/modules/xrdfs/XrdPrinter.h                  |  51 ----------
           core/modules/xrdfs/testMySqlFs_2.cc              |   6 +-
           core/modules/xrdoss/QservOss.cc                  |  27 ++---
           core/modules/xrdoss/QservOss.h                   |  10 +-
           core/modules/xrdoss/SConscript.test              |   2 +-
           core/modules/xrdsvc/SsiService.cc                |  57 ++++-------
           core/modules/xrdsvc/SsiService.h                 |   4 -
           core/modules/xrdsvc/SsiSession.cc                | 119 ++++++++++++-----------
           core/modules/xrdsvc/SsiSession.h                 |  10 +-
           core/modules/xrdsvc/plugin.cc                    |   2 -
           site_scons/state.py                              |   8 +-
           ups/qserv.table                                  |   1 +

          It all looks fine and straightforward. There's even some cleanup in the comments, which I really appreciate. Good job.

          Show
          danielw Daniel Wang [X] (Inactive) added a comment - I looked at admin/templates/server/etc/init.d/xrootd | 1 + admin/templates/server/etc/log4xrootd.properties | 8 ++ core/modules/SConscript | 12 +-- core/modules/xrdfs/MySqlFs.cc | 43 ++++---- core/modules/xrdfs/MySqlFs.h | 10 +- core/modules/xrdfs/MySqlFsDirectory.cc | 6 +- core/modules/xrdfs/MySqlFsDirectory.h | 13 ++- core/modules/xrdfs/MySqlFsFile.cc | 89 ++++++++--------- core/modules/xrdfs/MySqlFsFile.h | 5 +- core/modules/xrdfs/SConscript.test | 2 +- core/modules/xrdfs/XrdLogger.h | 53 ---------- core/modules/xrdfs/XrdPrinter.h | 51 ---------- core/modules/xrdfs/testMySqlFs_2.cc | 6 +- core/modules/xrdoss/QservOss.cc | 27 ++--- core/modules/xrdoss/QservOss.h | 10 +- core/modules/xrdoss/SConscript.test | 2 +- core/modules/xrdsvc/SsiService.cc | 57 ++++------- core/modules/xrdsvc/SsiService.h | 4 - core/modules/xrdsvc/SsiSession.cc | 119 ++++++++++++----------- core/modules/xrdsvc/SsiSession.h | 10 +- core/modules/xrdsvc/plugin.cc | 2 - site_scons/state.py | 8 +- ups/qserv.table | 1 + It all looks fine and straightforward. There's even some cleanup in the comments, which I really appreciate. Good job.
          Hide
          salnikov Andy Salnikov added a comment -

          I'll mark it as review complete, merging is delayed until we ready to switch (when log is in central distrib repo). This will need one or more rebasing.

          Show
          salnikov Andy Salnikov added a comment - I'll mark it as review complete, merging is delayed until we ready to switch (when log is in central distrib repo). This will need one or more rebasing.

            People

            • Assignee:
              salnikov Andy Salnikov
              Reporter:
              fritzm Fritz Mueller
              Reviewers:
              Daniel Wang [X] (Inactive), Jacek Becla
              Watchers:
              Andy Salnikov, Daniel Wang [X] (Inactive), Jacek Becla, Kian-Tat Lim
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel