Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10096

Add unit test asserts for SpherePoint, SpherePointList and PointList

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      Add unit test asserts to lsst.afw.geom.utils:

      • assertSpherePointsAlmosttEqual
      • assertSpherePointListsAlmostEqual
      • assertPointListsAlmostEqual

      and unit tests for them. This work is needed (or at least very useful) for the new WCS classes.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            Ian: do you have time to review some of the remaining packages in this ticket? The changes are fairly innocuous. Please do as many as you have time for and I can assign the rest to somebody else.

            Show
            rowen Russell Owen added a comment - Ian: do you have time to review some of the remaining packages in this ticket? The changes are fairly innocuous. Please do as many as you have time for and I can assign the rest to somebody else.
            Hide
            nlust Nate Lust added a comment -

            Russell, I did look at all the tickets linked on Jira, I just didn't have any comments for most of them, as they almost all looked fine.

            Show
            nlust Nate Lust added a comment - Russell, I did look at all the tickets linked on Jira, I just didn't have any comments for most of them, as they almost all looked fine.
            Hide
            sullivan Ian Sullivan added a comment -

            I can certainly look at these, though if Nate has already reviewed them I don't want to duplicate his effort. Nate, does that mean you looked at all 17 pull requests, or should I look at the ones that don't show as having a reviewer?

            Show
            sullivan Ian Sullivan added a comment - I can certainly look at these, though if Nate has already reviewed them I don't want to duplicate his effort. Nate, does that mean you looked at all 17 pull requests, or should I look at the ones that don't show as having a reviewer?
            Hide
            rowen Russell Owen added a comment - - edited

            Good point. I had assumed that Nate only looked at the 3 the marked as reviewed before marking this JIRA ticket as "reviewed" but I see I was wrong. Sorry to have bothered you!

            Show
            rowen Russell Owen added a comment - - edited Good point. I had assumed that Nate only looked at the 3 the marked as reviewed before marking this JIRA ticket as "reviewed" but I see I was wrong. Sorry to have bothered you!
            Hide
            nlust Nate Lust added a comment -

            I looked at all 17, but only made comments on tickets I felt that needed comments. I did not mark anything as reviewed or not reviewed on github, as I am morally opposed to making a reviewed status in two places. As Jira is our official one, that is where I set the reviewed status. If you want someone to have a look at the others feel free, but as you said they are all innocuous and looked good to me.

            Show
            nlust Nate Lust added a comment - I looked at all 17, but only made comments on tickets I felt that needed comments. I did not mark anything as reviewed or not reviewed on github, as I am morally opposed to making a reviewed status in two places. As Jira is our official one, that is where I set the reviewed status. If you want someone to have a look at the others feel free, but as you said they are all innocuous and looked good to me.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Nate Lust
              Watchers:
              Ian Sullivan, Krzysztof Findeisen, Nate Lust, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.