Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_base
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:Measurement-S14-4
-
Team:Data Release Production
Description
SingleFrameSkyCoordPlugin is using the Footprint Peak, not the centroid slot. According to comments in the code, this is a workaround for some problem with centroids. This needs to be fixed.
Attachments
Activity
The SkyCoord plugin should use the centroid unless usePeak=True. It is False by default. Do you want me to remove this option?
Perry Gee
added a comment - The SkyCoord plugin should use the centroid unless usePeak=True. It is False by default. Do you want me to remove this option? Yes, please do, assuming we no longer need it for testing purposes.
Note that I fixed ForcedTransformedCentroid already on another issue, I think.
This is a tiny change to remove the usePeak option from SkyCoord
Perry Gee
added a comment - This is a tiny change to remove the usePeak option from SkyCoord Code is in u/pgee/DM-1012
python/lsst/meas/base/plugins.py | 10 +---------
tests/testSkyCoordBasic.py | 1 -
2 files changed, 1 insertion
, 10 deletions
Perry Gee
added a comment - Code is in u/pgee/ DM-1012
python/lsst/meas/base/plugins.py | 10 +---------
tests/testSkyCoordBasic.py | 1 -
2 files changed, 1 insertion , 10 deletions
Should fix ForcedTransformedCentroidPlugin at the same time (see comments in the code).