Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1012

remove temporary workaround in new SkyCoord algorithm

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:

      Description

      SingleFrameSkyCoordPlugin is using the Footprint Peak, not the centroid slot. According to comments in the code, this is a workaround for some problem with centroids. This needs to be fixed.

        Attachments

          Activity

          Hide
          jbosch Jim Bosch added a comment -

          Should fix ForcedTransformedCentroidPlugin at the same time (see comments in the code).

          Show
          jbosch Jim Bosch added a comment - Should fix ForcedTransformedCentroidPlugin at the same time (see comments in the code).
          Hide
          pgee Perry Gee added a comment -

          The SkyCoord plugin should use the centroid unless usePeak=True. It is False by default. Do you want me to remove this option?

          Show
          pgee Perry Gee added a comment - The SkyCoord plugin should use the centroid unless usePeak=True. It is False by default. Do you want me to remove this option?
          Hide
          jbosch Jim Bosch added a comment -

          Yes, please do, assuming we no longer need it for testing purposes.

          Note that I fixed ForcedTransformedCentroid already on another issue, I think.

          Show
          jbosch Jim Bosch added a comment - Yes, please do, assuming we no longer need it for testing purposes. Note that I fixed ForcedTransformedCentroid already on another issue, I think.
          Hide
          pgee Perry Gee added a comment -

          This is a tiny change to remove the usePeak option from SkyCoord

          Show
          pgee Perry Gee added a comment - This is a tiny change to remove the usePeak option from SkyCoord
          Hide
          pgee Perry Gee added a comment -

          Code is in u/pgee/DM-1012

          python/lsst/meas/base/plugins.py | 10 +---------
          tests/testSkyCoordBasic.py | 1 -
          2 files changed, 1 insertion, 10 deletions

          Show
          pgee Perry Gee added a comment - Code is in u/pgee/ DM-1012 python/lsst/meas/base/plugins.py | 10 +--------- tests/testSkyCoordBasic.py | 1 - 2 files changed, 1 insertion , 10 deletions
          Hide
          jbosch Jim Bosch added a comment -

          Looks good, ready to merge.

          Show
          jbosch Jim Bosch added a comment - Looks good, ready to merge.

            People

            Assignee:
            pgee Perry Gee
            Reporter:
            jbosch Jim Bosch
            Reviewers:
            Jim Bosch
            Watchers:
            Jim Bosch, Perry Gee
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.