Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10130

Clarify alert contents regarding "full" DIASource history

    Details

    • Team:
      Architecture

      Description

      On reviewing DMS-REQ-0274, Mario Juric no longer thinks that "all previous DIASource records corresponding to the object" is correct. Now that DPDD states that we only do characterization for 12 months of history, it makes sense for the alert to only include 12 months as well. Fixing this will require edits to DMS-REQ-0274 in LSE-61 and the alert packet description in LSE-163.

        Attachments

          Issue Links

            Activity

            Hide
            lguy Leanne Guy added a comment -

            It looks does not look like this update to LSE-61 requirement  DMS-REQ-0274 was made before closing this ticket. I will create a new ticket to make the update to LSE-61 

            Show
            lguy Leanne Guy added a comment - It looks does not look like this update to LSE-61 requirement  DMS-REQ-0274 was made before closing this ticket. I will create a new ticket to make the update to LSE-61 
            Hide
            ebellm Eric Bellm added a comment -

            Tim Jenness It looks like we made this change in LSE-163 but forgot to make the corresponding change in LSE-61 to DMS-REQ-0274.

            Show
            ebellm Eric Bellm added a comment - Tim Jenness It looks like we made this change in LSE-163 but forgot to make the corresponding change in LSE-61 to DMS-REQ-0274.
            Hide
            ebellm Eric Bellm added a comment -

            Looks good to me.

            Show
            ebellm Eric Bellm added a comment - Looks good to me.
            Hide
            tjenness Tim Jenness added a comment -

            Eric Bellm can you take another look at this?

            Show
            tjenness Tim Jenness added a comment - Eric Bellm can you take another look at this?
            Hide
            tjenness Tim Jenness added a comment -

            Thanks. I've updated the pull request and updated the PDF at https://lse-163.lsst.io/v/DM-10130/dpdd.pdf

            I've included your suggested wording. I've also updated section 3.5.1 as requested. I believe the bullet point referring to matching Object IDs also needed updating with the 12 months. Can you please take another look?

            Show
            tjenness Tim Jenness added a comment - Thanks. I've updated the pull request and updated the PDF at https://lse-163.lsst.io/v/DM-10130/dpdd.pdf I've included your suggested wording. I've also updated section 3.5.1 as requested. I believe the bullet point referring to matching Object IDs also needed updating with the 12 months. Can you please take another look?
            Hide
            ebellm Eric Bellm added a comment -

            I think it would be clearer to say,

            "including all DIASources from the last 12 months that are linked with the SSObject or DIAObject."

            Section 4.5.1 ("Information Contained in Each Alert") needs updating as well; it still says "All previous DIASource records."

            Show
            ebellm Eric Bellm added a comment - I think it would be clearer to say, "including all DIASources from the last 12 months that are linked with the SSObject or DIAObject." Section 4.5.1 ("Information Contained in Each Alert") needs updating as well; it still says "All previous DIASource records."
            Hide
            tjenness Tim Jenness added a comment -

            Is this change enough for you?

            Show
            tjenness Tim Jenness added a comment - Is this change enough for you?
            Hide
            tjenness Tim Jenness added a comment -

            The current baselined version of LSE-163 says:

            including the full light curves.

            the new version now says:

            including 12 months of light curves of the SSObject or DIAObject, including all other DIASources linked with the SSObject or DIAObject.

            The pull request on this ticket replaces "the full" with "12 months", the rest of the new text was added by Kian-Tat Lim a while a go. I'm not sure what the text after the comma is saying now. If we say "12 months of light curve for the DIAObject" doesn't that imply we are including the DIASources associated with that DIAObject?

            Show
            tjenness Tim Jenness added a comment - The current baselined version of LSE-163 says: including the full light curves. the new version now says: including 12 months of light curves of the SSObject or DIAObject, including all other DIASources linked with the SSObject or DIAObject. The pull request on this ticket replaces "the full" with "12 months", the rest of the new text was added by Kian-Tat Lim a while a go. I'm not sure what the text after the comma is saying now. If we say "12 months of light curve for the DIAObject" doesn't that imply we are including the DIASources associated with that DIAObject?

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                tjenness Tim Jenness
                Reviewers:
                Eric Bellm
                Watchers:
                Colin Slater, Eric Bellm, Kian-Tat Lim, Leanne Guy, Maria Patterson [X] (Inactive), Mario Juric, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel