Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1014

Detailed documentation for GaussianCentroid

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Sprint:
      Science Pipelines DM-W15-4, Science Pipelines DM-S15-1
    • Team:
      Data Release Production

      Description

      We need more detailed documentation for the GaussianCentroid algorithm, in terms of how it actually computes the centroid. We (Jim and Perry) have done what we can, but we need help from whoever actually wrote it (RHL, we think) to provide the rest. In particular:

      • Additional detail should be filled in in the class Doxygen for GaussianCentroidAlgorithm, in GaussianCentroid.h
      • The "noPeak" flag field description and name should be compared to what the algorithm actually does with it. It looks to me like it's a bit misnamed (and maybe shouldn't be considered an error condition at all, if we want to run this on difference images), but I'm not sure.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Leanne Guy — this very old ticket is an appeal for help from Robert Lupton, whose LSST time is entirely owned by the SST. Do you think it likely that this will become an SST priority?

            Show
            swinbank John Swinbank added a comment - Leanne Guy — this very old ticket is an appeal for help from Robert Lupton , whose LSST time is entirely owned by the SST. Do you think it likely that this will become an SST priority?
            Hide
            rhl Robert Lupton added a comment -

            As I noted on another ticket, this algorithm was removed from the stack:

            commit e8008769f3ed8268e5c852bf1f4faeb288f8a1b4 (origin/tickets/DM-13395)

            Author: Paul Price <price@astro.princeton.edu>

            Date:   Thu Feb 1 11:57:14 2018 -0500

             

                remove GaussianCentroid

                

                Per RFC-437.

                

                SdssCentroid performs at least as well and is faster. GaussianCentroid

                is not valgrind-clean, and removing it will save on maintenance.

            Show
            rhl Robert Lupton added a comment - As I noted on another ticket, this algorithm was removed from the stack: commit e8008769f3ed8268e5c852bf1f4faeb288f8a1b4 (origin/tickets/ DM-13395 ) Author: Paul Price <price@astro.princeton.edu> Date:   Thu Feb 1 11:57:14 2018 -0500       remove GaussianCentroid          Per RFC-437 .          SdssCentroid performs at least as well and is faster. GaussianCentroid     is not valgrind-clean, and removing it will save on maintenance.
            Hide
            swinbank John Swinbank added a comment -

            Thanks Robert Lupton!

            Show
            swinbank John Swinbank added a comment - Thanks Robert Lupton !

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              jbosch Jim Bosch
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Leanne Guy, Robert Lupton
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.