Details
-
Type:
Story
-
Status: Invalid
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_base
-
Labels:
-
Story Points:1
-
Sprint:Science Pipelines DM-W15-4, Science Pipelines DM-S15-1
-
Team:Data Release Production
Description
We need more detailed documentation for the GaussianCentroid algorithm, in terms of how it actually computes the centroid. We (Jim and Perry) have done what we can, but we need help from whoever actually wrote it (RHL, we think) to provide the rest. In particular:
- Additional detail should be filled in in the class Doxygen for GaussianCentroidAlgorithm, in GaussianCentroid.h
- The "noPeak" flag field description and name should be compared to what the algorithm actually does with it. It looks to me like it's a bit misnamed (and maybe shouldn't be considered an error condition at all, if we want to run this on difference images), but I'm not sure.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
| Labels | Measurement | AppsPlanning |
| Labels | AppsPlanning | SciencePipelines |
| Team | Princeton [ 10301 ] |
| Sprint | Science Pipelines DM-W15-4 [ 120 ] |
| Rank | Ranked higher |
| Sprint | Science Pipelines DM-W15-4 [ 120 ] | Science Pipelines DM-W15-4, Science Pipelines DM-W15-5 [ 120, 129 ] |
| Rank | Ranked higher |
| Sprint | Science Pipelines DM-W15-4, Science Pipelines DM-W15-5 [ 120, 129 ] | Science Pipelines DM-W15-4, Science Pipelines DM-S15-1 [ 120, 140 ] |
| Sprint | Science Pipelines DM-W15-4, Science Pipelines DM-S15-1 [ 120, 140 ] | Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, Science Pipelines DM-S15-2 [ 120, 140, 151 ] |
| Rank | Ranked higher |
| Sprint | Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, Science Pipelines DM-S15-2 [ 120, 140, 151 ] | Science Pipelines DM-W15-4, Science Pipelines DM-S15-1 [ 120, 140 ] |
| Epic Link |
|
| Epic Link |
|
| Assignee | Robert Lupton [ rhl ] |
| Labels | SciencePipelines | SciencePipelines dm-sst |
| Remote Link | This issue links to "Page (Confluence)" [ 20155 ] |
As I noted on another ticket, this algorithm was removed from the stack:
commit e8008769f3ed8268e5c852bf1f4faeb288f8a1b4 (origin/tickets/
DM-13395)Author: Paul Price <price@astro.princeton.edu>
Date: Thu Feb 1 11:57:14 2018 -0500
remove GaussianCentroid
Per
RFC-437.
SdssCentroid performs at least as well and is faster. GaussianCentroid
is not valgrind-clean, and removing it will save on maintenance.
| Resolution | Done [ 10000 ] | |
| Status | To Do [ 10001 ] | Invalid [ 11005 ] |
Thanks Robert Lupton!
Leanne Guy — this very old ticket is an appeal for help from Robert Lupton, whose LSST time is entirely owned by the SST. Do you think it likely that this will become an SST priority?