Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10156

Replace all uses of Calib with PhotoCalib

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • afw
    • 10
    • AP S19-2, AP S19-3, AP S19-4, AP S19-5
    • Alert Production

    Description

      Search and replace all "Calib" with "PhotoCalib", delete the Calib tests from afw/tests/testColors.py, delete all the Calib code (include/Calib.h, src/Calib.cc, python/calib.cc), and then see what breaks. The API is now quite different and it's immutable, so there are going to be quite a few more changes necessary. Hopefully most of them can be taken care of by globally replacing "getMagnitude" with "countsToMagnitude", but we'll see.

      Attachments

        Issue Links

          Activity

            Parejkoj John Parejko added a comment -

            I have fixed the above error, and now the "Before fitting calcChi2" values are the same as the w_2019_10 run, but the fluxFit chi2 printed a bit further down is inf.

            Parejkoj John Parejko added a comment - I have fixed the above error, and now the "Before fitting calcChi2" values are the same as the w_2019_10 run, but the fluxFit chi2 printed a bit further down is inf .
            Parejkoj John Parejko added a comment - - edited

            Success, I think. At least, no infinite chi2 values, and the results look similar to the w_2019_10 run, though not identical. See /home/parejkoj/lsst/meas_mosaic/mosaic-10156.log

            What is the next step here? Chasing rebasing is starting to get tricky.

            Parejkoj John Parejko added a comment - - edited Success, I think. At least, no infinite chi2 values, and the results look similar to the w_2019_10 run, though not identical. See /home/parejkoj/lsst/meas_mosaic/mosaic-10156.log What is the next step here? Chasing rebasing is starting to get tricky.

            Hurray!

            sophiereed was going to look at the pipe_analysis outputs (to check for surprises in performance) on an HSC RC2 run using DM-10156. sophiereed, will you send me the path to the repo with multiband outputs generated with DM-10156?

            yusra Yusra AlSayyad added a comment - Hurray! sophiereed was going to look at the pipe_analysis outputs (to check for surprises in performance) on an HSC RC2 run using DM-10156 . sophiereed , will you send me the path to the repo with multiband outputs generated with DM-10156 ?
            Parejkoj John Parejko added a comment -

            Thank you everyone for the reviews!

            Final post-rebase jenkins run (after merging DM-17029): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29636/pipeline

            Parejkoj John Parejko added a comment - Thank you everyone for the reviews! Final post-rebase jenkins run (after merging DM-17029 ): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29636/pipeline
            Parejkoj John Parejko added a comment -

            Huge thank you to all of the reviewers! Got it into this weekly!

            Merged and done (even if Jira doesn't seem to recognize a few of the merged PRs).

            Parejkoj John Parejko added a comment - Huge thank you to all of the reviewers! Got it into this weekly! Merged and done (even if Jira doesn't seem to recognize a few of the merged PRs).

            People

              Parejkoj John Parejko
              Parejkoj John Parejko
              Nate Lust, Yusra AlSayyad
              Chris Morrison [X] (Inactive), Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Simon Krughoff (Inactive), Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.