Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10156

Replace all uses of Calib with PhotoCalib

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      10
    • Epic Link:
    • Sprint:
      AP S19-2, AP S19-3, AP S19-4, AP S19-5
    • Team:
      Alert Production

      Description

      Search and replace all "Calib" with "PhotoCalib", delete the Calib tests from afw/tests/testColors.py, delete all the Calib code (include/Calib.h, src/Calib.cc, python/calib.cc), and then see what breaks. The API is now quite different and it's immutable, so there are going to be quite a few more changes necessary. Hopefully most of them can be taken care of by globally replacing "getMagnitude" with "countsToMagnitude", but we'll see.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16903 Deprecate/remove abMagFromFlux/fluxFromABMag in Calib

          • To Do
          contains

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15544 ExposureCatalog should support new photoCalib objects

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-10346 Allow depersist of old Calib objects as PhotoCalibs

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17029 Update LoadReferenceObjectsTask to output fluxes in nanojansky

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-18067 Add fluxMag0 PhotoCalib factory function

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16926 File an RFC describing the Calib->PhotoCalib transition

          • Done
          is triggering

          Bug - A problem which impairs or prevents the functions of the product. DM-19015 HSC warp making is broken with doApplyUberCal=True

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-18544 Add python-level deprecation warnings for Calib interface

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-19207 Remove deprecated Calib interfaces after next release

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-18157 Make photoCalib hashable

          • Won't Fix
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17873 Deprecated hasX() methods in ExposureInfo

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-19265 Jacobian lost in meas_mosaic photometric solution

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-18492 Update forcedPhotCcd to use PhotoCalib.calibrateImage

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            22 older comments
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            I have fixed the above error, and now the "Before fitting calcChi2" values are the same as the w_2019_10 run, but the fluxFit chi2 printed a bit further down is inf.

            Show
            Parejkoj John Parejko added a comment - I have fixed the above error, and now the "Before fitting calcChi2" values are the same as the w_2019_10 run, but the fluxFit chi2 printed a bit further down is inf .
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            Success, I think. At least, no infinite chi2 values, and the results look similar to the w_2019_10 run, though not identical. See /home/parejkoj/lsst/meas_mosaic/mosaic-10156.log

            What is the next step here? Chasing rebasing is starting to get tricky.

            Show
            Parejkoj John Parejko added a comment - - edited Success, I think. At least, no infinite chi2 values, and the results look similar to the w_2019_10 run, though not identical. See /home/parejkoj/lsst/meas_mosaic/mosaic-10156.log What is the next step here? Chasing rebasing is starting to get tricky.
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            Hurray!

            Sophie Reed was going to look at the pipe_analysis outputs (to check for surprises in performance) on an HSC RC2 run using DM-10156. Sophie Reed, will you send me the path to the repo with multiband outputs generated with DM-10156?

            Show
            yusra Yusra AlSayyad added a comment - Hurray! Sophie Reed was going to look at the pipe_analysis outputs (to check for surprises in performance) on an HSC RC2 run using DM-10156 . Sophie Reed , will you send me the path to the repo with multiband outputs generated with DM-10156 ?
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thank you everyone for the reviews!

            Final post-rebase jenkins run (after merging DM-17029): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29636/pipeline

            Show
            Parejkoj John Parejko added a comment - Thank you everyone for the reviews! Final post-rebase jenkins run (after merging DM-17029 ): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29636/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Huge thank you to all of the reviewers! Got it into this weekly!

            Merged and done (even if Jira doesn't seem to recognize a few of the merged PRs).

            Show
            Parejkoj John Parejko added a comment - Huge thank you to all of the reviewers! Got it into this weekly! Merged and done (even if Jira doesn't seem to recognize a few of the merged PRs).

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Nate Lust, Yusra AlSayyad
              Watchers:
              Chris Morrison [X] (Inactive), Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Simon Krughoff, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.