Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw
-
Labels:
-
Story Points:10
-
Epic Link:
-
Sprint:AP S19-2, AP S19-3, AP S19-4, AP S19-5
-
Team:Alert Production
Description
Search and replace all "Calib" with "PhotoCalib", delete the Calib tests from afw/tests/testColors.py, delete all the Calib code (include/Calib.h, src/Calib.cc, python/calib.cc), and then see what breaks. The API is now quite different and it's immutable, so there are going to be quite a few more changes necessary. Hopefully most of them can be taken care of by globally replacing "getMagnitude" with "countsToMagnitude", but we'll see.
Attachments
Issue Links
- blocks
-
DM-16903 Deprecate/remove abMagFromFlux/fluxFromABMag in Calib
- To Do
- contains
-
DM-15544 ExposureCatalog should support new photoCalib objects
- Done
- is blocked by
-
DM-10346 Allow depersist of old Calib objects as PhotoCalibs
- Done
-
DM-17029 Update LoadReferenceObjectsTask to output fluxes in nanojansky
- Done
-
DM-18067 Add fluxMag0 PhotoCalib factory function
- Done
-
DM-16926 File an RFC describing the Calib->PhotoCalib transition
- Done
- is triggering
-
DM-19015 HSC warp making is broken with doApplyUberCal=True
- Done
-
DM-18544 Add python-level deprecation warnings for Calib interface
- Done
-
DM-19207 Remove deprecated Calib interfaces after next release
- Done
-
DM-18157 Make photoCalib hashable
- Won't Fix
- relates to
-
DM-17873 Deprecated hasX() methods in ExposureInfo
- To Do
-
DM-19265 Jacobian lost in meas_mosaic photometric solution
- Done
-
DM-18492 Update forcedPhotCcd to use PhotoCalib.calibrateImage
- Invalid
Activity
Field | Original Value | New Value |
---|---|---|
Epic Link |
|
Story Points | 10 | |
Assignee | John Parejko [ parejkoj ] |
Status | To Do [ 10001 ] | In Progress [ 3 ] |
Comment | [ I wish we could have replaced Calib with PhotoCalib for this, but I think I can manage it (with a bunch of internal conversions). ] |
Status | In Progress [ 3 ] | To Do [ 10001 ] |
Sprint | AP S19-2 [ 830 ] |
Sprint | AP S19-2 [ 830 ] | AP S19-2, AP S19-3 [ 830, 831 ] |
Status | To Do [ 10001 ] | In Progress [ 3 ] |
Sprint | AP S19-2, AP S19-3 [ 830, 831 ] | AP S19-2, AP S19-3, AP S19-4 [ 830, 831, 832 ] |
Reviewers | Chris Morrison, Christopher Waters, Ian Sullivan, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cmorrison, cwaters, sullivan, krzys, mrawls, nlust, krughoff, yusra ] | |
Status | In Progress [ 3 ] | In Review [ 10004 ] |
Reviewers | Chris Morrison, Christopher Waters, Ian Sullivan, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cmorrison, cwaters, sullivan, krzys, mrawls, nlust, krughoff, yusra ] | Chris Morrison, Christopher Waters, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cmorrison, cwaters, krzys, mrawls, nlust, krughoff, yusra ] |
Reviewers | Chris Morrison, Christopher Waters, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cmorrison, cwaters, krzys, mrawls, nlust, krughoff, yusra ] | Christopher Waters, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cwaters, krzys, mrawls, nlust, krughoff, yusra ] |
Reviewers | Christopher Waters, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cwaters, krzys, mrawls, nlust, krughoff, yusra ] | Christopher Waters, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cwaters, mrawls, nlust, krughoff, yusra ] |
Reviewers | Christopher Waters, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cwaters, mrawls, nlust, krughoff, yusra ] | Christopher Waters, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cwaters, nlust, krughoff, yusra ] |
Reviewers | Christopher Waters, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cwaters, nlust, krughoff, yusra ] | Nate Lust, Simon Krughoff, Yusra AlSayyad [ nlust, krughoff, yusra ] |
Watchers | Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad ] | Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Simon Krughoff, Yusra AlSayyad [ Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Simon Krughoff, Yusra AlSayyad ] |
Reviewers | Nate Lust, Simon Krughoff, Yusra AlSayyad [ nlust, krughoff, yusra ] | Nate Lust, Yusra AlSayyad [ nlust, yusra ] |
Watchers | Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad ] | Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Simon Krughoff, Yusra AlSayyad [ Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Simon Krughoff, Yusra AlSayyad ] |
Sprint | AP S19-2, AP S19-3, AP S19-4 [ 830, 831, 832 ] | AP S19-2, AP S19-3, AP S19-4, AP S19-5 [ 830, 831, 832, 833 ] |
Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Resolution | Done [ 10000 ] | |
Status | Reviewed [ 10101 ] | Done [ 10002 ] |