Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10156

Replace all uses of Calib with PhotoCalib

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      10
    • Sprint:
      AP S19-2, AP S19-3, AP S19-4, AP S19-5
    • Team:
      Alert Production

      Description

      Search and replace all "Calib" with "PhotoCalib", delete the Calib tests from afw/tests/testColors.py, delete all the Calib code (include/Calib.h, src/Calib.cc, python/calib.cc), and then see what breaks. The API is now quite different and it's immutable, so there are going to be quite a few more changes necessary. Hopefully most of them can be taken care of by globally replacing "getMagnitude" with "countsToMagnitude", but we'll see.

        Attachments

          Issue Links

            Activity

            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Epic Link DM-10153 [ 31778 ]
            Parejkoj John Parejko made changes -
            Story Points 10
            Assignee John Parejko [ parejkoj ]
            Parejkoj John Parejko made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Parejkoj John Parejko made changes -
            Comment [ I wish we could have replaced Calib with PhotoCalib for this, but I think I can manage it (with a bunch of internal conversions). ]
            Parejkoj John Parejko made changes -
            Status In Progress [ 3 ] To Do [ 10001 ]
            Parejkoj John Parejko made changes -
            Link This issue is blocked by DM-16903 [ DM-16903 ]
            Parejkoj John Parejko made changes -
            Link This issue is blocked by DM-10346 [ DM-10346 ]
            Parejkoj John Parejko made changes -
            Link This issue contains DM-15544 [ DM-15544 ]
            swinbank John Swinbank made changes -
            Link This issue is blocked by DM-16926 [ DM-16926 ]
            swinbank John Swinbank made changes -
            Sprint AP S19-2 [ 830 ]
            swinbank John Swinbank made changes -
            Sprint AP S19-2 [ 830 ] AP S19-2, AP S19-3 [ 830, 831 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-17873 [ DM-17873 ]
            Parejkoj John Parejko made changes -
            Link This issue is blocked by DM-18067 [ DM-18067 ]
            Parejkoj John Parejko made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            swinbank John Swinbank made changes -
            Sprint AP S19-2, AP S19-3 [ 830, 831 ] AP S19-2, AP S19-3, AP S19-4 [ 830, 831, 832 ]
            Parejkoj John Parejko made changes -
            Link This issue is triggering DM-18157 [ DM-18157 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-18492 [ DM-18492 ]
            Parejkoj John Parejko made changes -
            Link This issue is triggering DM-18544 [ DM-18544 ]
            Parejkoj John Parejko made changes -
            Reviewers Chris Morrison, Christopher Waters, Ian Sullivan, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cmorrison, cwaters, sullivan, krzys, mrawls, nlust, krughoff, yusra ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            sullivan Ian Sullivan made changes -
            Reviewers Chris Morrison, Christopher Waters, Ian Sullivan, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cmorrison, cwaters, sullivan, krzys, mrawls, nlust, krughoff, yusra ] Chris Morrison, Christopher Waters, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cmorrison, cwaters, krzys, mrawls, nlust, krughoff, yusra ]
            cmorrison Chris Morrison made changes -
            Reviewers Chris Morrison, Christopher Waters, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cmorrison, cwaters, krzys, mrawls, nlust, krughoff, yusra ] Christopher Waters, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cwaters, krzys, mrawls, nlust, krughoff, yusra ]
            krzys Krzysztof Findeisen made changes -
            Reviewers Christopher Waters, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cwaters, krzys, mrawls, nlust, krughoff, yusra ] Christopher Waters, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cwaters, mrawls, nlust, krughoff, yusra ]
            mrawls Meredith Rawls made changes -
            Reviewers Christopher Waters, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cwaters, mrawls, nlust, krughoff, yusra ] Christopher Waters, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cwaters, nlust, krughoff, yusra ]
            czw Christopher Waters made changes -
            Reviewers Christopher Waters, Nate Lust, Simon Krughoff, Yusra AlSayyad [ cwaters, nlust, krughoff, yusra ] Nate Lust, Simon Krughoff, Yusra AlSayyad [ nlust, krughoff, yusra ]
            nlust Nate Lust made changes -
            Watchers Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad ] Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Simon Krughoff, Yusra AlSayyad [ Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Simon Krughoff, Yusra AlSayyad ]
            krughoff Simon Krughoff made changes -
            Reviewers Nate Lust, Simon Krughoff, Yusra AlSayyad [ nlust, krughoff, yusra ] Nate Lust, Yusra AlSayyad [ nlust, yusra ]
            nlust Nate Lust made changes -
            Watchers Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad [ Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Nate Lust, Simon Krughoff, Yusra AlSayyad ] Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Simon Krughoff, Yusra AlSayyad [ Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Simon Krughoff, Yusra AlSayyad ]
            Parejkoj John Parejko made changes -
            Link This issue is blocked by DM-16903 [ DM-16903 ]
            Parejkoj John Parejko made changes -
            Link This issue blocks DM-16903 [ DM-16903 ]
            Parejkoj John Parejko made changes -
            Link This issue is blocked by DM-17029 [ DM-17029 ]
            swinbank John Swinbank made changes -
            Sprint AP S19-2, AP S19-3, AP S19-4 [ 830, 831, 832 ] AP S19-2, AP S19-3, AP S19-4, AP S19-5 [ 830, 831, 832, 833 ]
            yusra Yusra AlSayyad made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Parejkoj John Parejko made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            hchiang2 Hsin-Fang Chiang made changes -
            Link This issue is triggering DM-19015 [ DM-19015 ]
            Parejkoj John Parejko made changes -
            Link This issue is triggering DM-19207 [ DM-19207 ]
            lauren Lauren MacArthur made changes -
            Link This issue relates to DM-19265 [ DM-19265 ]

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Nate Lust, Yusra AlSayyad
                Watchers:
                Chris Morrison, Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Simon Krughoff, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel