Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1017

fix testForced.py

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:

      Description

      testForced.py is currently passing even though it probably should be failing: it's trying to get centroid values from a source which has neither a valid centroid slot or a Footprint with Peaks (I suspect because transforming a footprint might remove the peaks). Prior to DM-976, that would have caused a segfault; on DM-976, I've turned it into an exception, which is then turned into a warning by the measurement framework.

        Attachments

          Activity

          Hide
          pgee Perry Gee added a comment -

          Jim:

          I don't see any place in testForced.py where an undefined centroid slot is used.

          The setUp routine creates a catalog which transforms the footprint peaks (in the way that we never agreed that the Exposure transform code could do safely). But I don't think the centroid slot is used.

          testOnCcd does not seem to use a centroid, nor does testOnSameWcs.

          Did you fix this bug previously?

          Show
          pgee Perry Gee added a comment - Jim: I don't see any place in testForced.py where an undefined centroid slot is used. The setUp routine creates a catalog which transforms the footprint peaks (in the way that we never agreed that the Exposure transform code could do safely). But I don't think the centroid slot is used. testOnCcd does not seem to use a centroid, nor does testOnSameWcs. Did you fix this bug previously?
          Hide
          jbosch Jim Bosch added a comment -

          I think I might have, when I modified the default centroid slot for ForcedMeasurementTask. In any case, if you don't see log messages about an exception being raised and squashed when running the test, feel free to close this issue. That was the symptom that caused me to create this issue.

          Show
          jbosch Jim Bosch added a comment - I think I might have, when I modified the default centroid slot for ForcedMeasurementTask. In any case, if you don't see log messages about an exception being raised and squashed when running the test, feel free to close this issue. That was the symptom that caused me to create this issue.
          Hide
          pgee Perry Gee added a comment -

          As I explained in my email, I do not see this problem in any of the testForced.py tests.

          Show
          pgee Perry Gee added a comment - As I explained in my email, I do not see this problem in any of the testForced.py tests.

            People

            Assignee:
            pgee Perry Gee
            Reporter:
            jbosch Jim Bosch
            Reviewers:
            Jim Bosch
            Watchers:
            Jim Bosch, Perry Gee
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.