Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10200

Change default for invert in Box2I constructors, and then remove invert entirely.

    Details

    • Type: Story
    • Status: In Progress
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: afw
    • Labels:

      Description

      Implement RFC-324 and inspect any code calling the affected Box2I constructors to see if it needs to be modified. The hard part is the latter.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Sophie Reed and Jim Bosch are doing this as a pair-programming exercise.

            Show
            jbosch Jim Bosch added a comment - Sophie Reed and Jim Bosch are doing this as a pair-programming exercise.
            Hide
            jbosch Jim Bosch added a comment -

            We've made changes in geom and afw that remove the default for invert in order to catch code that is using the old default.  So far we have not found any cases where the invert=True behavior was desired.  We'll return to this in the future.

            Show
            jbosch Jim Bosch added a comment - We've made changes in geom and afw that remove the default for invert in order to catch code that is using the old default.  So far we have not found any cases where the invert=True behavior was desired.  We'll return to this in the future.
            Hide
            yusra Yusra AlSayyad added a comment - - edited

            Dan Taranu and Yusra AlSayyad joined in on the Party Programming today to inspect Box2I and Box2D constructors and add explicit invert=False. So far haven't found any cases where invert=True made sense.

            Update: We looked at and updated the following 30 packages. I got afw compiling in the evening. Now all the packages that depend on afw and geom need to be tested.

             

            geom Jim+Sophie pushed
            afw Jim+Sophie+Yusra  pushed
            display_matplotlib Sophie no branch
            shapelet Sophie pushed
            ctrl_orca Sophie no branch
            display_ds9 Sophie no branch
            obs_base Sophie pushed
            skymap Sophie pushed
            display_firefly Sophie no branch
            ctrl_execute Sophie no branch
            obs_test Sophie pushed
            ctrl_platform_lsstvc Sophie no branch
            pipe_base Sophie no branch
            ctrl_pool Sophie no branch
            cp_pipe Sophie no branch
            coadd_utils Sophie pushed
            meas_base Sophie pushed
            coadd_chisquared Yusra pushed
            meas_algorithms Yusra pushed
            meas_extensions_photometryKron Yusra no branch
            meas_deblender Yusra pushed
            meas_extensions_psfex Yusra no branch
            ip_diffim Yusra pushed
            ip_isr Yusra pushed
            meas_astrom Yusra pushed
            meas_modelfit Yusra pushed
            meas_extensions_simpleShape Yusra pushed
            meas_extensions_astrometryNet Yusra pushed
            meas_extensions_convolved Yusra pushed
            obs_monocam Yusra pushed
            meas_extensions_shapeHSM Yusra pushed
            obs_ctio0m9 Yusra no branch
            pipe_tasks Yusra pushed
            obs_sdss Dan pushed
            obs_lsstSim Dan pushed
            obs_cfht Dan pushed
            synpipe Dan no branch
            pipe_drivers Dan pushed
            obs_subaru Dan pushed
            ci_ctio0m9 Dan no branch
            obs_decam Dan pushed
            meas_mosaic Yusra pushed
            obs_comCam Dan pushed
            validation_data_decam Dan no branch
            lsst_obs Dan no branch
            validate_drp Dan no branch
            validation_data_cfht Dan no branch
            lsst_apps Dan no branch
            testdata_jointcal Dan no branch
            jointcal Yusra pushed
            Show
            yusra Yusra AlSayyad added a comment - - edited Dan Taranu and Yusra AlSayyad joined in on the Party Programming today to inspect Box2I and Box2D constructors and add explicit invert=False . So far haven't found any cases where invert=True made sense. Update: We looked at and updated the following 30 packages. I got afw  compiling in the evening. Now all the packages that depend on afw and geom need to be tested.   geom Jim+Sophie pushed afw Jim+Sophie+Yusra  pushed display_matplotlib Sophie no branch shapelet Sophie pushed ctrl_orca Sophie no branch display_ds9 Sophie no branch obs_base Sophie pushed skymap Sophie pushed display_firefly Sophie no branch ctrl_execute Sophie no branch obs_test Sophie pushed ctrl_platform_lsstvc Sophie no branch pipe_base Sophie no branch ctrl_pool Sophie no branch cp_pipe Sophie no branch coadd_utils Sophie pushed meas_base Sophie pushed coadd_chisquared Yusra pushed meas_algorithms Yusra pushed meas_extensions_photometryKron Yusra no branch meas_deblender Yusra pushed meas_extensions_psfex Yusra no branch ip_diffim Yusra pushed ip_isr Yusra pushed meas_astrom Yusra pushed meas_modelfit Yusra pushed meas_extensions_simpleShape Yusra pushed meas_extensions_astrometryNet Yusra pushed meas_extensions_convolved Yusra pushed obs_monocam Yusra pushed meas_extensions_shapeHSM Yusra pushed obs_ctio0m9 Yusra no branch pipe_tasks Yusra pushed obs_sdss Dan pushed obs_lsstSim Dan pushed obs_cfht Dan pushed synpipe Dan no branch pipe_drivers Dan pushed obs_subaru Dan pushed ci_ctio0m9 Dan no branch obs_decam Dan pushed meas_mosaic Yusra pushed obs_comCam Dan pushed validation_data_decam Dan no branch lsst_obs Dan no branch validate_drp Dan no branch validation_data_cfht Dan no branch lsst_apps Dan no branch testdata_jointcal Dan no branch jointcal Yusra pushed

              People

              • Assignee:
                sophiereed Sophie Reed
                Reporter:
                jbosch Jim Bosch
                Watchers:
                Jim Bosch, John Parejko, Krzysztof Findeisen, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Summary Panel