Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10225

Ingest IMGTYPE along with other header keys

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • obs_ctio0m9
    • None
    • 1
    • DRP S17-5
    • Data Release Production

    Description

      Ingest IMGTYPE along with other header keys. Add a translator so that these end up with useful/sane values.

      Attachments

        Activity

          Looks good, just a few minor comments and a fix to ensure that you are using the appropriate wavelength.

          fred3m Fred Moolekamp added a comment - Looks good, just a few minor comments and a fix to ensure that you are using the appropriate wavelength.

          OK, I believe I have addressed all comments. Please re-review, and let me know if it's OK to merge.

          mfisherlevine Merlin Fisher-Levine added a comment - OK, I believe I have addressed all comments. Please re-review, and let me know if it's OK to merge.

          mfisherlevine — I'm sure you know this, but just a reminder that you need to rebase out the "respond to review comments" commit before you can merge.

          swinbank John Swinbank added a comment - mfisherlevine — I'm sure you know this, but just a reminder that you need to rebase out the "respond to review comments" commit before you can merge.

          The only comment I have is that the docstring still doesn't specify what type of python object the metadata md is (or at least the duck type). Is this obvious to someone who has written an obs package? Add this and it will be ok to merge.

          fred3m Fred Moolekamp added a comment - The only comment I have is that the docstring still doesn't specify what type of python object the metadata md is (or at least the duck type). Is this obvious to someone who has written an obs package? Add this and it will be ok to merge.
          mfisherlevine Merlin Fisher-Levine added a comment - - edited

          It is a daf.base.propertyContainer.propertyList.PropertyList, but given that these functions are only called implicitly, and they are passed in this and only this, and one doesn't get a choice in that, I think that specifying that md is the metadata in the docstring is probably more than sufficient.

          Anyone writing an obs_package will either know this/find this obvious, or will be struggling with a lot more than just this (due to the lack of docs for writing an obs_package).

          mfisherlevine Merlin Fisher-Levine added a comment - - edited It is a daf.base.propertyContainer.propertyList.PropertyList , but given that these functions are only called implicitly, and they are passed in this and only this, and one doesn't get a choice in that, I think that specifying that md is the metadata in the docstring is probably more than sufficient. Anyone writing an obs_package will either know this/find this obvious, or will be struggling with a lot more than just this (due to the lack of docs for writing an obs_package).

          Merged.

          mfisherlevine Merlin Fisher-Levine added a comment - Merged.

          People

            mfisherlevine Merlin Fisher-Levine
            mfisherlevine Merlin Fisher-Levine
            Fred Moolekamp
            Fred Moolekamp, John Swinbank, Merlin Fisher-Levine, Robert Lupton
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.