Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_ctio0m9
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:DRP S17-5
-
Team:Data Release Production
Description
Ingest IMGTYPE along with other header keys. Add a translator so that these end up with useful/sane values.
Attachments
Activity
OK, I believe I have addressed all comments. Please re-review, and let me know if it's OK to merge.
Merlin Fisher-Levine — I'm sure you know this, but just a reminder that you need to rebase out the "respond to review comments" commit before you can merge.
The only comment I have is that the docstring still doesn't specify what type of python object the metadata md is (or at least the duck type). Is this obvious to someone who has written an obs package? Add this and it will be ok to merge.
Fred Moolekamp
added a comment - The only comment I have is that the docstring still doesn't specify what type of python object the metadata md is (or at least the duck type). Is this obvious to someone who has written an obs package? Add this and it will be ok to merge. It is a daf.base.propertyContainer.propertyList.PropertyList, but given that these functions are only called implicitly, and they are passed in this and only this, and one doesn't get a choice in that, I think that specifying that md is the metadata in the docstring is probably more than sufficient.
Anyone writing an obs_package will either know this/find this obvious, or will be struggling with a lot more than just this (due to the lack of docs for writing an obs_package).
Merged.
Looks good, just a few minor comments and a fix to ensure that you are using the appropriate wavelength.