Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10225

Ingest IMGTYPE along with other header keys

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_ctio0m9
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP S17-5
    • Team:
      Data Release Production

      Description

      Ingest IMGTYPE along with other header keys. Add a translator so that these end up with useful/sane values.

        Attachments

          Activity

          Hide
          fred3m Fred Moolekamp added a comment -

          Looks good, just a few minor comments and a fix to ensure that you are using the appropriate wavelength.

          Show
          fred3m Fred Moolekamp added a comment - Looks good, just a few minor comments and a fix to ensure that you are using the appropriate wavelength.
          Hide
          mfisherlevine Merlin Fisher-Levine added a comment -

          OK, I believe I have addressed all comments. Please re-review, and let me know if it's OK to merge.

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - OK, I believe I have addressed all comments. Please re-review, and let me know if it's OK to merge.
          Hide
          swinbank John Swinbank added a comment -

          Merlin Fisher-Levine — I'm sure you know this, but just a reminder that you need to rebase out the "respond to review comments" commit before you can merge.

          Show
          swinbank John Swinbank added a comment - Merlin Fisher-Levine — I'm sure you know this, but just a reminder that you need to rebase out the "respond to review comments" commit before you can merge.
          Hide
          fred3m Fred Moolekamp added a comment -

          The only comment I have is that the docstring still doesn't specify what type of python object the metadata md is (or at least the duck type). Is this obvious to someone who has written an obs package? Add this and it will be ok to merge.

          Show
          fred3m Fred Moolekamp added a comment - The only comment I have is that the docstring still doesn't specify what type of python object the metadata md is (or at least the duck type). Is this obvious to someone who has written an obs package? Add this and it will be ok to merge.
          Hide
          mfisherlevine Merlin Fisher-Levine added a comment - - edited

          It is a daf.base.propertyContainer.propertyList.PropertyList, but given that these functions are only called implicitly, and they are passed in this and only this, and one doesn't get a choice in that, I think that specifying that md is the metadata in the docstring is probably more than sufficient.

          Anyone writing an obs_package will either know this/find this obvious, or will be struggling with a lot more than just this (due to the lack of docs for writing an obs_package).

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - - edited It is a daf.base.propertyContainer.propertyList.PropertyList , but given that these functions are only called implicitly, and they are passed in this and only this, and one doesn't get a choice in that, I think that specifying that md is the metadata in the docstring is probably more than sufficient. Anyone writing an obs_package will either know this/find this obvious, or will be struggling with a lot more than just this (due to the lack of docs for writing an obs_package).
          Hide
          mfisherlevine Merlin Fisher-Levine added a comment -

          Merged.

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - Merged.

            People

            Assignee:
            mfisherlevine Merlin Fisher-Levine
            Reporter:
            mfisherlevine Merlin Fisher-Levine
            Reviewers:
            Fred Moolekamp
            Watchers:
            Fred Moolekamp, John Swinbank, Merlin Fisher-Levine, Robert Lupton
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.