Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10237

Error in blendedness debiasing calculation

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      See the last few comments on https://hsc-jira.astro.princeton.edu/jira/browse/HSC-1316.

      We should try to come up with a unit test for this too, but if that looks to hard we should defer it to another ticket so we don't hold up the fix.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-10129 Process HSC RC dataset using Stack version chosen for the full S17B reprocessing

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-10266 Release hscPipe 5.0-beta4

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Is this a blocker for DM-10129?

            Show
            swinbank John Swinbank added a comment - Is this a blocker for DM-10129 ?
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Ideally, yes, but it'll probably have a fairly small effect on a small piece of the overall processing, so we won't miss out on much if it doesn't make it in.

            Show
            jbosch Jim Bosch added a comment - Ideally, yes, but it'll probably have a fairly small effect on a small piece of the overall processing, so we won't miss out on much if it doesn't make it in.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Yusra AlSayyad, do you think you could turn this around today? I'm hoping it won't be too bad. I certainly don't expect you to go deep into the math for this; I've been checking that with Surhud More over on the HSC JIRA, so I think you can just take a look at the usual structural/stylistic things.

            Show
            jbosch Jim Bosch added a comment - Yusra AlSayyad , do you think you could turn this around today? I'm hoping it won't be too bad. I certainly don't expect you to go deep into the math for this; I've been checking that with Surhud More over on the HSC JIRA, so I think you can just take a look at the usual structural/stylistic things.
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            Jim Bosch, Yes, I'll take a look today.

            Show
            yusra Yusra AlSayyad added a comment - Jim Bosch , Yes, I'll take a look today.
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            Looks good. I left two minor inline comments in the PR.

            Show
            yusra Yusra AlSayyad added a comment - Looks good. I left two minor inline comments in the PR.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Comments addressed and merged to master.

            Show
            jbosch Jim Bosch added a comment - Comments addressed and merged to master.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Jim Bosch, John Swinbank, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.