Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10252

getOutputId() assumes keys will exist, and doesn't use butler to retrieve them

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_drivers
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP S17-5
    • Team:
      Data Release Production

      Description

      In constructCalibs.py, getOutputId() assumes certain keys will exist exist within a dataId. Whilst this information will likely exist in the registry, it shouldn't already exist in the dataId (that's not what they're for), and these should be retrieved at this point using the butler.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          fred3m Fred Moolekamp added a comment -

          Looks good, ok to merge.

          Show
          fred3m Fred Moolekamp added a comment - Looks good, ok to merge.
          Hide
          Permalink
          price Paul Price added a comment -

          I think some changes should be re-thought: comments on GitHub PR.

          Show
          price Paul Price added a comment - I think some changes should be re-thought: comments on GitHub PR.
          Hide
          Permalink
          mfisherlevine Merlin Fisher-Levine added a comment -

          Merged.

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - Merged.

            People

            Assignee:
            mfisherlevine Merlin Fisher-Levine
            Reporter:
            mfisherlevine Merlin Fisher-Levine
            Reviewers:
            Fred Moolekamp
            Watchers:
            Fred Moolekamp, John Swinbank, Merlin Fisher-Levine, Paul Price, Robert Lupton
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.