Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_ctio0m9, pipe_drivers
-
Labels:None
-
Story Points:12
-
Epic Link:
-
Sprint:DRP S17-5, DRP S17-6, DRP F17-1
-
Team:Data Release Production
Description
Get the pipe_drivers contruct_*.py scripts running to make master calibs for obs_ctio0m9.
Currently this doesn't work, and a number of bug fixes are/will be necessary, likely in both pipe_drivers and the prototype obs_ctio0m9.
Attachments
Issue Links
- has to be done before
-
DM-10565 Get source detection and astrometry "working" in obs_ctio0m9
- Done
-
DM-10944 Decide (and maybe move) where darkTime and other header keys are scraped
- Invalid
- is blocked by
-
DM-9991 Provide functional obs_ctio0m9
- Done
- relates to
-
DM-10270 isrTask does not provide config option for defects
- Done
I'm pretty uncomfortable with the changes to pipe_tasks. Passing around mappers and accessing the internal standardization methods seems dangerous. I understand the desire not to duplicate code, so maybe that's why you didn't use a translate function. That can be avoided by putting the code in a free function and calling it in both translate_taiObs and std_raw_md. That would mean you do not need the changes in pipe_tasks.
Another general comment is that the coding standard asks for docstrings for every method and class. There are many methods in this changes et that have no docstring at all and many others where the docstring does not adhere to our standard (i.e. naming all input and output variables).
I'm not quite done with the review, but I'll post this now so you can look at them.