Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10254

Compiler warning: fabs used for integer types

    Details

    • Type: Improvement
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      Compiling results with clang in this warning:

      src/image/ImagePca.cc:393:46: note: use function 'std::abs' instead
                              double const delta = ::fabs(*fptr - iptr.image());
                                                   ^~~~~~
                                                   std::abs
      

      The obvious fix is to use std::abs instead.

      Krzysztof Findeisen would it make any sense to fix this as part of your general afw cleanup?

        Attachments

          Issue Links

            Activity

            No work has yet been logged on this issue.

              People

              • Assignee:
                Unassigned
                Reporter:
                rowen Russell Owen
                Watchers:
                Krzysztof Findeisen, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel