Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10257

Fix compiler warnings in afw

    Details

    • Story Points:
      4
    • Sprint:
      Alert Production S17 - 5, Alert Production S17 - 6
    • Team:
      Alert Production

      Description

      Running

      scons --clean
      scons -s
      

      in afw reveals a large number of warnings, including unsafe casts, misuse of typeid, and signed/unsigned comparisons. These warnings should be fixed where practical. Note that some warnings are caused by template instantiations in third-party libraries, and cannot be fixed inside the Stack.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            All GCC warnings (except one) have been fixed. However, the child tasks above mention warnings that do not appear in GCC, so I will need to rebuild afw on Clang to complete this ticket.

            Show
            krzys Krzysztof Findeisen added a comment - All GCC warnings (except one) have been fixed. However, the child tasks above mention warnings that do not appear in GCC, so I will need to rebuild afw on Clang to complete this ticket.
            Hide
            krzys Krzysztof Findeisen added a comment -

            Hi Russell Owen, could you review this afw cleanup ticket? It could use the attention of a C++ expert.

            Show
            krzys Krzysztof Findeisen added a comment - Hi Russell Owen , could you review this afw cleanup ticket? It could use the attention of a C++ expert.
            Hide
            rowen Russell Owen added a comment -

            Looks excellent. I put two minor suggestions on github (one of which was to run clang-format 5.0 on one of the files, but in fact it'd be better to run it on all the modified C++ files, though that may have already been done for most of them).

            Show
            rowen Russell Owen added a comment - Looks excellent. I put two minor suggestions on github (one of which was to run clang-format 5.0 on one of the files, but in fact it'd be better to run it on all the modified C++ files, though that may have already been done for most of them).

              People

              • Assignee:
                krzys Krzysztof Findeisen
                Reporter:
                krzys Krzysztof Findeisen
                Reviewers:
                Russell Owen
                Watchers:
                Chris Morrison, John Parejko, Krzysztof Findeisen, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel