Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1027

sconsUtils.tests.run needs to check for test failures and return exit status

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: sconsUtils
    • Labels:
      None
    • Team:
      Data Release Production

      Description

      We want test failures to cause scons to return a non-zero exit status, instead of forcing people to look for .failed files or messages in the build output.

        Attachments

          Issue Links

            Activity

            Hide
            mjuric Mario Juric added a comment -

            PS: For reviewing this patch (and to test gihub): https://github.com/LSST/sconsUtils/pull/1

            LSST repos are automatically mirrored to github every minute (so don't commit anything to the github repos themselves, it will get deleted on next mirror).

            Show
            mjuric Mario Juric added a comment - PS: For reviewing this patch (and to test gihub): https://github.com/LSST/sconsUtils/pull/1 LSST repos are automatically mirrored to github every minute (so don't commit anything to the github repos themselves, it will get deleted on next mirror).
            Hide
            rhl Robert Lupton added a comment -

            Good catch. Running -j 1 reveals only one failure.

            I'll take another look.

            Show
            rhl Robert Lupton added a comment - Good catch. Running -j 1 reveals only one failure. I'll take another look.
            Hide
            rhl Robert Lupton added a comment -

            OK, a new implementation that checks the status of all tests just before scons exits.

            57eea23 Robert Lupton the Good Fix implementation so that all tests are run, not just the first one.

            Show
            rhl Robert Lupton added a comment - OK, a new implementation that checks the status of all tests just before scons exits. 57eea23 Robert Lupton the Good Fix implementation so that all tests are run, not just the first one.
            Hide
            rhl Robert Lupton added a comment -

            Merged to master as:

            934a82c Robert Lupton the Good Merge remote-tracking branch 'origin/tickets/DM-1027' #close DM-1027

            But jira didn't seem to notice

            Show
            rhl Robert Lupton added a comment - Merged to master as: 934a82c Robert Lupton the Good Merge remote-tracking branch 'origin/tickets/ DM-1027 ' #close DM-1027 But jira didn't seem to notice
            Hide
            mjuric Mario Juric added a comment -

            It did notice. Look at the Activity tab (or 'All' tab). Note that there can be up to a ~minute-two delay for Jira to get updated (because of the mirroring).

            Show
            mjuric Mario Juric added a comment - It did notice. Look at the Activity tab (or 'All' tab). Note that there can be up to a ~minute-two delay for Jira to get updated (because of the mirroring).

              People

              • Assignee:
                rhl Robert Lupton
                Reporter:
                ktl Kian-Tat Lim
                Reviewers:
                Kian-Tat Lim, Mario Juric
                Watchers:
                Kian-Tat Lim, Mario Juric, Robert Lupton, Robyn Allsman [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel