Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10287

Add measurement plugin to store footprint area

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:

      Description

      This is a trivial feature request that would have also been very useful on DM-9962. In terms of effort it should be "in the noise" of everything else blocking DM-10266, so I'm going to try to get it in.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Nate Lust, could you take a look at this tiny ticket? All changes in meas_base - at least for now; it's possible I'll have to make a similarly trivial to the demo's expected results, but Jenkins hasn't yet gotten back to me on that question.

            Show
            jbosch Jim Bosch added a comment - Nate Lust , could you take a look at this tiny ticket? All changes in meas_base - at least for now; it's possible I'll have to make a similarly trivial to the demo's expected results, but Jenkins hasn't yet gotten back to me on that question.
            Hide
            jbosch Jim Bosch added a comment -

            The demo check is insensitive to the addition of new columns, so it is indeed just the meas_base branch.

            Show
            jbosch Jim Bosch added a comment - The demo check is insensitive to the addition of new columns, so it is indeed just the meas_base branch.
            Hide
            nlust Nate Lust added a comment -

            The code all looks fine except for one minor comment on the pr. As a general note I wondered why this plugin is needed, and why you chose to make it a single frame plugin, as it seems it could have been a catalog calculation plugin. Is there something else in single frame measurement that needs this data early? This really seems to just be measuring something off the catalog and seems more appropriate for the other task.

            Show
            nlust Nate Lust added a comment - The code all looks fine except for one minor comment on the pr. As a general note I wondered why this plugin is needed, and why you chose to make it a single frame plugin, as it seems it could have been a catalog calculation plugin. Is there something else in single frame measurement that needs this data early? This really seems to just be measuring something off the catalog and seems more appropriate for the other task.
            Hide
            jbosch Jim Bosch added a comment -

            Yup, it should be a CatalogCalculation; I forgot that was an option. Will do.

            Show
            jbosch Jim Bosch added a comment - Yup, it should be a CatalogCalculation; I forgot that was an option. Will do.
            Hide
            jbosch Jim Bosch added a comment -

            Rewritten as a CatalogCalculation. Will merge after another Jenkins run.

            Show
            jbosch Jim Bosch added a comment - Rewritten as a CatalogCalculation. Will merge after another Jenkins run.
            Hide
            nlust Nate Lust added a comment -

            Sounds good

            Show
            nlust Nate Lust added a comment - Sounds good
            Hide
            jbosch Jim Bosch added a comment -

            Merged to master.

            Show
            jbosch Jim Bosch added a comment - Merged to master.

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Nate Lust
                Watchers:
                Jim Bosch, Nate Lust
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: