Fix Version/s: None
Sprint:Alert Production S17 - 5
The cast at : https://github.com/lsst/jointcal/blob/master/python/lsst/jointcal/jointcalCoadd.py#L54 is not supported anymore and is probably useless since the pybind11 migration
- relates to
DM-10595 Add test for jointcalCoadd.py
Dominique: since we don't have any tests for this, you'll have to try to run it through your pipeline to see if this fixes it.
Maria: can you please review the handful of code changes?
"and clean up jointcalCoadd" does not make it easy for me to tell what you did here by just reading the commit history.
Can you please split your commits? It looks like you did the following in some irrelevant-ish order, so I suggest:
- Remove unsupported tanWcs cast
- Remove deprecated applyjointcalResults function
- Remove immediate=True default in dataRef
Fine for me otherwise, so if you get those and Dominique approves then -> Reviewed.
Dominique Boutigny found another bug, which I've fixed, and so it should work for his purposes now.
Wish we had a test for this code, but it would take a bit to figure out how to write one (
DM-10595 filed to deal with it).
Merged and done.
This is blocking Dominique Boutigny, so I'll tackle it now.