Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10288

afwImage.TanWcs.cast() not supported anymore in jointcalCoadd

    Details

      Description

      The cast at : https://github.com/lsst/jointcal/blob/master/python/lsst/jointcal/jointcalCoadd.py#L54 is not supported anymore and is probably useless since the pybind11 migration

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            This is blocking Dominique Boutigny, so I'll tackle it now.

            Show
            Parejkoj John Parejko added a comment - This is blocking Dominique Boutigny , so I'll tackle it now.
            Hide
            Parejkoj John Parejko added a comment -

            Dominique: since we don't have any tests for this, you'll have to try to run it through your pipeline to see if this fixes it.

            Maria: can you please review the handful of code changes?

            Show
            Parejkoj John Parejko added a comment - Dominique: since we don't have any tests for this, you'll have to try to run it through your pipeline to see if this fixes it. Maria: can you please review the handful of code changes?
            Hide
            mtpatter Maria Patterson [X] (Inactive) added a comment -

            Ok.

            "and clean up jointcalCoadd" does not make it easy for me to tell what you did here by just reading the commit history.

            Can you please split your commits? It looks like you did the following in some irrelevant-ish order, so I suggest:

            • Remove unsupported tanWcs cast
            • Remove deprecated applyjointcalResults function
            • Remove immediate=True default in dataRef

            Fine for me otherwise, so if you get those and Dominique approves then -> Reviewed.

            Show
            mtpatter Maria Patterson [X] (Inactive) added a comment - Ok. "and clean up jointcalCoadd" does not make it easy for me to tell what you did here by just reading the commit history. Can you please split your commits? It looks like you did the following in some irrelevant-ish order, so I suggest: Remove unsupported tanWcs cast Remove deprecated applyjointcalResults function Remove immediate=True default in dataRef Fine for me otherwise, so if you get those and Dominique approves then -> Reviewed.
            Hide
            Parejkoj John Parejko added a comment -

            Fair point. I broke it up.

            Show
            Parejkoj John Parejko added a comment - Fair point. I broke it up.
            Hide
            Parejkoj John Parejko added a comment -

            Dominique Boutigny found another bug, which I've fixed, and so it should work for his purposes now.

            Wish we had a test for this code, but it would take a bit to figure out how to write one (DM-10595 filed to deal with it).

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Dominique Boutigny found another bug, which I've fixed, and so it should work for his purposes now. Wish we had a test for this code, but it would take a bit to figure out how to write one ( DM-10595 filed to deal with it). Merged and done.

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                boutigny Dominique Boutigny
                Reviewers:
                Dominique Boutigny, Maria Patterson [X] (Inactive)
                Watchers:
                Dominique Boutigny, John Parejko, Maria Patterson [X] (Inactive), Nicolas Chotard
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel