Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10288

afwImage.TanWcs.cast() not supported anymore in jointcalCoadd

    XMLWordPrintable

Details

    • 1
    • Alert Production S17 - 5
    • Alert Production

    Description

      The cast at : https://github.com/lsst/jointcal/blob/master/python/lsst/jointcal/jointcalCoadd.py#L54 is not supported anymore and is probably useless since the pybind11 migration

      Attachments

        Issue Links

          Activity

            This is blocking boutigny, so I'll tackle it now.

            Parejkoj John Parejko added a comment - This is blocking boutigny , so I'll tackle it now.

            Dominique: since we don't have any tests for this, you'll have to try to run it through your pipeline to see if this fixes it.

            Maria: can you please review the handful of code changes?

            Parejkoj John Parejko added a comment - Dominique: since we don't have any tests for this, you'll have to try to run it through your pipeline to see if this fixes it. Maria: can you please review the handful of code changes?

            Ok.

            "and clean up jointcalCoadd" does not make it easy for me to tell what you did here by just reading the commit history.

            Can you please split your commits? It looks like you did the following in some irrelevant-ish order, so I suggest:

            • Remove unsupported tanWcs cast
            • Remove deprecated applyjointcalResults function
            • Remove immediate=True default in dataRef

            Fine for me otherwise, so if you get those and Dominique approves then -> Reviewed.

            mtpatter Maria Patterson [X] (Inactive) added a comment - Ok. "and clean up jointcalCoadd" does not make it easy for me to tell what you did here by just reading the commit history. Can you please split your commits? It looks like you did the following in some irrelevant-ish order, so I suggest: Remove unsupported tanWcs cast Remove deprecated applyjointcalResults function Remove immediate=True default in dataRef Fine for me otherwise, so if you get those and Dominique approves then -> Reviewed.

            Fair point. I broke it up.

            Parejkoj John Parejko added a comment - Fair point. I broke it up.
            Parejkoj John Parejko added a comment -

            boutigny found another bug, which I've fixed, and so it should work for his purposes now.

            Wish we had a test for this code, but it would take a bit to figure out how to write one (DM-10595 filed to deal with it).

            Merged and done.

            Parejkoj John Parejko added a comment - boutigny found another bug, which I've fixed, and so it should work for his purposes now. Wish we had a test for this code, but it would take a bit to figure out how to write one ( DM-10595 filed to deal with it). Merged and done.

            People

              Parejkoj John Parejko
              boutigny Dominique Boutigny
              Dominique Boutigny, Maria Patterson [X] (Inactive)
              Dominique Boutigny, John Parejko, Maria Patterson [X] (Inactive), Nicolas Chotard
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.