Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10302

Rename "*_flux" fields to "*_instFlux" in SourceCatalogs

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      8
    • Epic Link:
    • Sprint:
      AP F18-3, AP F18-4
    • Team:
      Alert Production

      Description

      This is the implementation ticket for RFC-322. The implementation is as follows:

      • Rename all of our *Flux_flux/*Flux_fluxSigma table fields to *Flux_instFlux*Flux_instFluxSigma to hold the post-ISR counts.
      • Add *Flux_flux and *Flux_mag fields for the post-calibrated flux (in Maggies) and magnitudes.
        *Rename the InstFlux slot to GaussianFlux, and remove the InstMag slot.
      • Add associated documentation to the above.
      • Pass these changes on to the relevant database groups to update e.g. cat.

      Implementing this will wait until Calib is removed from the stack and replaced by PhotoCalib (not yet scheduled, but likely within the next couple months).

        Attachments

          Issue Links

          is blocked by

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-10153 Replace Calib with finished PhotoCalib

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-322 Rename "*_flux" fields to "*_instFlux" in SourceCatalogs

          • Implemented

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-510 Rename table getters and setters for fluxes as per RFC-322

          • Implemented
          is triggering

          Bug - A problem which impairs or prevents the functions of the product. DM-15869 Fix for renaming *_flux to *_instFlux

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15796 Update documentation to reflect flux->instFlux change

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15837 mosaic.py error "Field with name 'i_fluxErr' not found"

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15853 obs_lsstCam default processCcd config needs updates

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16215 obs_lsstCam default forcedPhotCoadd config needs updates

          • Done
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-15891 Error in flux/instFlux alias setting following DM-10302

          • Done

          Bug - A problem which impairs or prevents the functions of the product. DM-15916 Make meas_mosaic backwards compatible with *_flux --> *_instFlux rename

          • Done

          Bug - A problem which impairs or prevents the functions of the product. DM-16182 Update pipelines.lsst.io getting started for field name changes in parts 3 and 6 example data access

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13231 Make photoCalib outField write to _flux instead of _calFlux

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            11 older comments
            Hide
            Permalink
            rowen Russell Owen added a comment -

            My guess is this should be version 3, especially since there were old "instFlux" fields (though by a different name?), but Jim Bosch may have a more informed option.

            Show
            rowen Russell Owen added a comment - My guess is this should be version 3, especially since there were old "instFlux" fields (though by a different name?), but Jim Bosch may have a more informed option.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            If in doubt, increment the version.  Integers are cheap.

            Show
            jbosch Jim Bosch added a comment - If in doubt, increment the version.  Integers are cheap.
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            New run with schema version 3 defined:
            https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28663/pipeline

            Show
            Parejkoj John Parejko added a comment - - edited New run with schema version 3 defined: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28663/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            The work as described here is now merged, and I've made a Community post about it.

            Michael Wood-Vasey: I hear your concerns about documentation and tutorials. I'll take a look at the dev guide and other such docs tomorrow, and I'll see what I can do about the tutorials as well, but I make no promises about those or other jupyter notebooks. My changes should allow backward compatibility with the old schemas, so things should continue to at least work.

            Show
            Parejkoj John Parejko added a comment - The work as described here is now merged, and I've made a Community post about it. Michael Wood-Vasey : I hear your concerns about documentation and tutorials. I'll take a look at the dev guide and other such docs tomorrow, and I'll see what I can do about the tutorials as well, but I make no promises about those or other jupyter notebooks. My changes should allow backward compatibility with the old schemas, so things should continue to at least work.
            Hide
            Permalink
            wmwood-vasey Michael Wood-Vasey added a comment -

            :+1:

            Great, thanks John Parejko
            Community Post looks good and helpful.
            Thanks, everyone, for versioning the schema!

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - :+1: Great, thanks John Parejko Community Post looks good and helpful. Thanks, everyone, for versioning the schema!

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Russell Owen
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Maria Patterson [X] (Inactive), Michael Wood-Vasey, Russell Owen, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.