Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10302

Rename "*_flux" fields to "*_instFlux" in SourceCatalogs

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      8
    • Sprint:
      AP F18-3, AP F18-4
    • Team:
      Alert Production

      Description

      This is the implementation ticket for RFC-322. The implementation is as follows:

      • Rename all of our *Flux_flux/*Flux_fluxSigma table fields to *Flux_instFlux*Flux_instFluxSigma to hold the post-ISR counts.
      • Add *Flux_flux and *Flux_mag fields for the post-calibrated flux (in Maggies) and magnitudes.
        *Rename the InstFlux slot to GaussianFlux, and remove the InstMag slot.
      • Add associated documentation to the above.
      • Pass these changes on to the relevant database groups to update e.g. cat.

      Implementing this will wait until Calib is removed from the stack and replaced by PhotoCalib (not yet scheduled, but likely within the next couple months).

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            My guess is this should be version 3, especially since there were old "instFlux" fields (though by a different name?), but Jim Bosch may have a more informed option.

            Show
            rowen Russell Owen added a comment - My guess is this should be version 3, especially since there were old "instFlux" fields (though by a different name?), but Jim Bosch may have a more informed option.
            Hide
            jbosch Jim Bosch added a comment -

            If in doubt, increment the version.  Integers are cheap.

            Show
            jbosch Jim Bosch added a comment - If in doubt, increment the version.  Integers are cheap.
            Hide
            Parejkoj John Parejko added a comment - - edited
            Show
            Parejkoj John Parejko added a comment - - edited New run with schema version 3 defined: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28663/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            The work as described here is now merged, and I've made a Community post about it.

            Michael Wood-Vasey: I hear your concerns about documentation and tutorials. I'll take a look at the dev guide and other such docs tomorrow, and I'll see what I can do about the tutorials as well, but I make no promises about those or other jupyter notebooks. My changes should allow backward compatibility with the old schemas, so things should continue to at least work.

            Show
            Parejkoj John Parejko added a comment - The work as described here is now merged, and I've made a Community post about it. Michael Wood-Vasey : I hear your concerns about documentation and tutorials. I'll take a look at the dev guide and other such docs tomorrow, and I'll see what I can do about the tutorials as well, but I make no promises about those or other jupyter notebooks. My changes should allow backward compatibility with the old schemas, so things should continue to at least work.
            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            :+1:

            Great, thanks John Parejko
            Community Post looks good and helpful.
            Thanks, everyone, for versioning the schema!

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - :+1: Great, thanks John Parejko Community Post looks good and helpful. Thanks, everyone, for versioning the schema!

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Russell Owen
                Watchers:
                Jim Bosch, John Parejko, John Swinbank, Maria Patterson [X] (Inactive), Michael Wood-Vasey, Russell Owen, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel