Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10308

Add support for box regions and magnitudes in brightObjectMasks

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Team:
      DM Science

      Description

      We need to include saturation trails and the scattered light off the channel stops in the y-band in BRIGHT_OBJECT masks.

      Please add support for box in ObjectMaskCatalog and AssembleCoaddTask.setBrightObjectMasks. In general these boxes will not be axis aligned, but for an initial implementation it is sufficient to assume that angle==0, pending the resolution of DM-10307.

      At the same time, please allow the input ds9 region files to specify a magnitude in the comment, following the id field.

        Attachments

          Issue Links

            Activity

            No builds found.
            rhl Robert Lupton created issue -
            rhl Robert Lupton made changes -
            Field Original Value New Value
            Link This issue relates to DM-10307 [ DM-10307 ]
            rhl Robert Lupton made changes -
            Reviewers Paul Price [ price ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            Hide
            price Paul Price added a comment -

            Minor comments made on GitHub PR.

            Show
            price Paul Price added a comment - Minor comments made on GitHub PR.
            price Paul Price made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            price Paul Price made changes -
            Link This issue blocks DM-10266 [ DM-10266 ]
            Hide
            rhl Robert Lupton added a comment -

            Responded to reviewers comments and merge to master

            Changes made things a bit more robust, and aided the transition to rotated boxes as some future point.

            Show
            rhl Robert Lupton added a comment - Responded to reviewers comments and merge to master Changes made things a bit more robust, and aided the transition to rotated boxes as some future point.
            rhl Robert Lupton made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Hide
            swinbank John Swinbank added a comment -

            (By the way: if you force-push your rebased changes onto the ticket branch as well as just merging them to master, GitHub will notice and close the PR automatically, and JIRA will mark the PR as "merged" rather than "declined". Makes it a tiny bit easier to see what's been going on.)

            Show
            swinbank John Swinbank added a comment - (By the way: if you force-push your rebased changes onto the ticket branch as well as just merging them to master, GitHub will notice and close the PR automatically, and JIRA will mark the PR as "merged" rather than "declined". Makes it a tiny bit easier to see what's been going on.)
            swinbank John Swinbank made changes -
            Team Project Science [ 11800 ]
            Hide
            tjenness Tim Jenness added a comment -

            (the trick is making sure that the branch is up to date before pushing the master changes. If you push the master merged branch and then the rebased ticket branch Github won't close the PR).

            Show
            tjenness Tim Jenness added a comment - (the trick is making sure that the branch is up to date before pushing the master changes. If you push the master merged branch and then the rebased ticket branch Github won't close the PR).
            swinbank John Swinbank made changes -
            Team Project Science [ 11800 ] DM Science [ 12218 ]

              People

              Assignee:
              rhl Robert Lupton
              Reporter:
              rhl Robert Lupton
              Reviewers:
              Paul Price
              Watchers:
              John Swinbank, Paul Price, Robert Lupton, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.