Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10336

DM-10271 seems to have broken afw

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      0.5
    • Sprint:
      DRP S17-5
    • Team:
      Data Release Production

      Description

      As of DM-10271 I can no longer build afw on my Mac. I see errors such as:

      In file included from python/lsst/afw/detection/peak.cc:33:
      include/lsst/afw/table/python/catalog.h:170:13: error: no matching function for call to 'PySlice_GetIndicesEx'
              if (PySlice_GetIndicesEx((PySliceObject*)s.ptr(), self.size(), &start, &stop, &step, &length) != 0) {
                  ^~~~~~~~~~~~~~~~~~~~
      python/lsst/afw/detection/peak.cc:114:42: note: in instantiation of function template specialization 'lsst::afw::table::python::declareCatalog<lsst::afw::detection::PeakRecord>' requested
            here
          auto clsPeakCatalog = table::python::declareCatalog<PeakRecord>(mod, "Peak");
                                               ^
      /Users/rowen/UW/LSST/lsstsw3/miniconda/include/python3.5m/sliceobject.h:43:17: note: candidate function not viable: no known conversion from 'PySliceObject *' to 'PyObject *'
            (aka '_object *') for 1st argument
      PyAPI_FUNC(int) PySlice_GetIndicesEx(PyObject *r, Py_ssize_t length,
                      ^
      

      I am using a Python 3 lsstsw stack on macOS 10.12.4 with the current clang: Apple LLVM version 8.1.0 (clang-802.0.42)

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Py2 Jenkins is in progress, but we might as well get this reviewed. Py3 Jenkins failed in meas_base due to something unrelated (I think master is broken there, too; I'll make a new issue for that).

            Show
            jbosch Jim Bosch added a comment - Py2 Jenkins is in progress, but we might as well get this reviewed. Py3 Jenkins failed in meas_base due to something unrelated (I think master is broken there, too; I'll make a new issue for that).
            Hide
            rowen Russell Owen added a comment -

            Thank you for the quick fix! It looks fine, though you might consider adding an explanatory code comment.

            Show
            rowen Russell Owen added a comment - Thank you for the quick fix! It looks fine, though you might consider adding an explanatory code comment.

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                rowen Russell Owen
                Reviewers:
                Russell Owen
                Watchers:
                Jim Bosch, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel