Details
-
Type:
Story
-
Status: Invalid
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_isr
-
Labels:None
-
Epic Link:
-
Team:Data Release Production
Description
(1) There is a unused config brighterFatterKernelFile in the IsrTask. It probably needs to be removed as Butler is used to retrieve the file now. Having a line like config.processCcd.isr.brighterFatterKernelFile='' in the config file is confusing while the brighter fatter kernel is read fine.
(2) The butler dataset type of the brighter fatter kernel file is inconsistent in ip_isr and obs_subaru. ip_isr wants brighterFatterKernel, while obs_subaru and obs_base want bfKernel.
It seems the brighter fatter correction has only been tested/used for subaru so far?
Attachments
Issue Links
Activity
The link in the last comment is now bad. A new one: https://github.com/lsst/ip_isr/blob/w.2017.20/python/lsst/ip/isr/isrTask.py#L400-L401
Hsin-Fang Chiang
added a comment - The link in the last comment is now bad. A new one: https://github.com/lsst/ip_isr/blob/w.2017.20/python/lsst/ip/isr/isrTask.py#L400-L401 DM-14396 duplicates part (2) of this ticket.
Hsin-Fang Chiang
added a comment - DM-14396 duplicates part (2) of this ticket. I believe that all the problems in this ticket were subsumed and fixed by DM-13293 and related work. If this turns out not to be the case please do re-file, but I think things should now be working.
Also Jim Bosch brought up that a failure to find the brighter-fatter kernel via the butler should probably be fatal error. This seems to be checked in ip_isr but I'm not sure if the HSC IsrTask wants such a check as well; it may already be done somewhere but I didn't trace it down.