Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10363

Jenkins regards lsst_dm_stack_demo failures as successes

    XMLWordPrintable

    Details

      Description

      See, for example https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/23363/console: the result is clearly a failure (there's a huge list of warnings), but the log concludes:

      *** Warning: output results not within error tolerance for: 
      The simple integration demo was successfully run.
      ------------------------------------------------------------------------------
       
      [PostBuildScript] - Execution post build scripts.
      [PostBuildScript] Build is not failure : do not execute script
      Archiving artifacts
      Recording fingerprints
      Finished: SUCCESS
      

      It shouldn't.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Pinging Frossie Economou because this a SQuaRE issue and it's pretty unfortunate: we should address it soon if possible.

            Show
            swinbank John Swinbank added a comment - Pinging Frossie Economou because this a SQuaRE issue and it's pretty unfortunate: we should address it soon if possible.
            Hide
            jhoblitt Joshua Hoblitt added a comment - - edited

            I believe that this should be resolved by the merge of https://github.com/lsst-sqre/buildbot-scripts/pull/32

            Show
            jhoblitt Joshua Hoblitt added a comment - - edited I believe that this should be resolved by the merge of https://github.com/lsst-sqre/buildbot-scripts/pull/32
            Hide
            swinbank John Swinbank added a comment - - edited

            Thanks for the fast turnaround, Joshua Hoblitt.

            I confirm that we're now seeing the system record an error when the demo fails: .

            However, the error we get is:

            *** Warning: output results not within error tolerance for: lsst_dm_stack_demo-master
            /home/jenkins-slave/workspace/stack-os-matrix/label/centos-7/python/py2/buildbot-scripts/lsstswBuild.sh: line 329: error: command not found
            Build step 'Execute shell' marked build as failure
            

            I suspect that's because line 329 of lsstswBuild.sh should read print_error rather than just error.

            Show
            swinbank John Swinbank added a comment - - edited Thanks for the fast turnaround, Joshua Hoblitt . I confirm that we're now seeing the system record an error when the demo fails: . However, the error we get is: *** Warning: output results not within error tolerance for: lsst_dm_stack_demo-master /home/jenkins-slave/workspace/stack-os-matrix/label/centos-7/python/py2/buildbot-scripts/lsstswBuild.sh: line 329: error: command not found Build step 'Execute shell' marked build as failure I suspect that's because line 329 of lsstswBuild.sh should read print_error rather than just error .
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            Well that was a testing fail.

            Show
            jhoblitt Joshua Hoblitt added a comment - Well that was a testing fail.
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            The fix was merged about an hour ago.

            Show
            jhoblitt Joshua Hoblitt added a comment - The fix was merged about an hour ago.

              People

              Assignee:
              jhoblitt Joshua Hoblitt
              Reporter:
              swinbank John Swinbank
              Reviewers:
              John Swinbank
              Watchers:
              John Swinbank, Joshua Hoblitt, Nate Lust
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.