Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10385

Add Key.isValid() check to BaseColumnView::operator[]

    XMLWordPrintable

Details

    • Story
    • Status: Invalid
    • Resolution: Done
    • None
    • afw
    • None
    • 1
    • Data Release Production

    Description

      Exceptions are much better than segfaults, especially in Python.

      Error should look like the one thrown by BaseRecord::operator[], which includes a helpful hint for the common case where the key is invalid because a slot was not defined.

      Attachments

        Issue Links

          Activity

            tjenness Tim Jenness added a comment -

            jbosch I assume this ticket is still valid. If DM-10626 is a duplicate can you please mark that one as invalid? Is DM-5855 related?

            tjenness Tim Jenness added a comment - jbosch I assume this ticket is still valid. If DM-10626 is a duplicate can you please mark that one as invalid? Is DM-5855 related?
            jbosch Jim Bosch added a comment -

            This has already been done. Not sure when, but DM-10626 is a duplicate that wasn't the one on which it was done.

            jbosch Jim Bosch added a comment - This has already been done. Not sure when, but DM-10626 is a duplicate that wasn't the one on which it was done.
            jbosch Jim Bosch added a comment -

            DM-5855 is related but not covered by the changes that have already been made, so I think that's still valid, even if the bad behavior is not exactly the same.

            jbosch Jim Bosch added a comment - DM-5855 is related but not covered by the changes that have already been made, so I think that's still valid, even if the bad behavior is not exactly the same.

            People

              Unassigned Unassigned
              jbosch Jim Bosch
              Jim Bosch, John Parejko, Meredith Rawls, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.