Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10413

Please complain louder if brightObjectMask cannot be found

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Team:
      Data Release Production

      Description

      The externally provided bright object masks (via the butler type "brightObjectMask") can be applied in AssembleCoaddTask with a config config.assembleCoadd.doMaskBrightObjects=True to mask bright stars and other troublesome objects. While the default doMaskBrightObjects has been True in obs_subaru, only a warning message is given when the bright object masks are not available in the repo, like this:

      (assembleCoadd.py:725)- Unable to read brightObjectMask for DataId(...): No locations for get: datasetType:brightObjectMask dataId:DataId(...)
      

      It would be better if users had to set a configuration to turn them off, with a hard error if they can't be found. Otherwise it's far too easy to run without them when you don't want to.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            I seem to recall this was a deliberate choice.... Robert Lupton?

            Show
            price Paul Price added a comment - I seem to recall this was a deliberate choice.... Robert Lupton ?
            Hide
            rhl Robert Lupton added a comment -

            I don't remember for sure, but I think I was trying to cover the case that we only had masks for part of the sky. I'm OK with changing this.

            Show
            rhl Robert Lupton added a comment - I don't remember for sure, but I think I was trying to cover the case that we only had masks for part of the sky. I'm OK with changing this.
            Hide
            jbosch Jim Bosch added a comment -

            Reviewing for CCB, I think this is still relevant, if not yet a high priority.

            Show
            jbosch Jim Bosch added a comment - Reviewing for CCB, I think this is still relevant, if not yet a high priority.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              hchiang2 Hsin-Fang Chiang
              Watchers:
              Hsin-Fang Chiang, Jim Bosch, John Swinbank, Paul Price, Robert Lupton
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.