Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10452

Create bboxFromIraf function in obs_base utils

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP S17-6
    • Team:
      Data Release Production

      Description

      Create (move) utility function to create a bbox from from an IRAF box from obs package to obs_base so others can use it.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          4 older comments
          Hide
          Permalink
          mfisherlevine Merlin Fisher-Levine added a comment -

          Responding to your comments/questions in order:

          1) Thank you!
          2) No, we don't have a spec per se...
          3) I don't know
          4) I don't know
          5) You can repeat "I don't know" as many times as needed for each of the weird cases you think up
          6) I don't know.

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - Responding to your comments/questions in order: 1) Thank you! 2) No, we don't have a spec per se... 3) I don't know 4) I don't know 5) You can repeat "I don't know" as many times as needed for each of the weird cases you think up 6) I don't know.
          Hide
          Permalink
          mfisherlevine Merlin Fisher-Levine added a comment -

          If you'd like, we can rename the function _bboxFromIrafForObsCtio0m9Only or something like that and stick it back in the obs_package if you prefer - I really don't know what the expectation for universality is here, and when it's OK to say garbage-in-garbage-out.

          I would think that perhaps supporting " as well as ' is reasonable, but negative indices are probably an acceptable (nay desirable?) place to fail perhaps?

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - If you'd like, we can rename the function _bboxFromIrafForObsCtio0m9Only or something like that and stick it back in the obs_package if you prefer - I really don't know what the expectation for universality is here, and when it's OK to say garbage-in-garbage-out. I would think that perhaps supporting " as well as ' is reasonable, but negative indices are probably an acceptable (nay desirable?) place to fail perhaps?
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          Fine. I don't like the lack of clear specs as to what we're doing here, but I guess this is as good as we're getting for now. You (Merlin Fisher-Levine) should perform code review on the test case, then merge this ticket when you're happy.

          Show
          swinbank John Swinbank added a comment - Fine. I don't like the lack of clear specs as to what we're doing here, but I guess this is as good as we're getting for now. You ( Merlin Fisher-Levine ) should perform code review on the test case, then merge this ticket when you're happy.
          Hide
          Permalink
          mfisherlevine Merlin Fisher-Levine added a comment -

          :pray:

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - :pray:
          Hide
          Permalink
          mfisherlevine Merlin Fisher-Levine added a comment -

          Merged.

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - Merged.

            People

            Assignee:
            mfisherlevine Merlin Fisher-Levine
            Reporter:
            mfisherlevine Merlin Fisher-Levine
            Reviewers:
            John Swinbank
            Watchers:
            John Swinbank, Merlin Fisher-Levine, Robert Lupton
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.