Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10487

obs_cfht needs to be updated in order to be compatible with latest CFHT data

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_cfht
    • Labels:
      None
    • Team:
      External

      Description

      obs_cfht is failing on recent CFHT data for 2 independent reasons :

      1. On old data the keyword "EXTNAME" appears 2 times in the fits header, the first one with the value "COMPRESSED_IMAGE" and the second one with the actual name of the extensions. While on some more recent data (not all !), there is only 1 occurrence of the "EXTNAME" keyword which contains the extension name. Notice that even if COMPRESSED_IMAGE is missing, the image is actually compressed.
      2. Recent images need new bad pixels mask files. These masks correspond to the addition of 4 more CCD in the focal plane (36-->40).

      The first fix is trivial and requires to override the getExtensionName method in ingest.py in order to check whether md.get("EXTNAME") is returning a tuple or a single value.

      The second issue requires to get the missing files from CFHT/Megacam (I got them from Jean-Charles Cuillandre) and to convert them in the format expected by obs_cfht. I already did that a few years ago and need to retrieve the method...

      New filters have also been installed since period 2015A and should be defined in ingest.py

        Attachments

          Activity

          Hide
          krughoff Simon Krughoff added a comment -

          Two minor comments:
          I think you can take the print statement out of the mapper print(butlerLocation.locationList)
          I'm think making the mask filenames start with test is a little misleading. It seems like these are, in fact, meant to be used as first class citizens.

          Otherwise, good to go.

          Show
          krughoff Simon Krughoff added a comment - Two minor comments: I think you can take the print statement out of the mapper print(butlerLocation.locationList) I'm think making the mask filenames start with test is a little misleading. It seems like these are, in fact, meant to be used as first class citizens. Otherwise, good to go.
          Hide
          krughoff Simon Krughoff added a comment -

          Sorry it took so long to get to this.

          Show
          krughoff Simon Krughoff added a comment - Sorry it took so long to get to this.
          Hide
          boutigny Dominique Boutigny added a comment -

          Thanks Simon.
          Regarding the masks name starting with "test", I agree that it is a poor choice, unfortunately this is the "official" name from Elixir and it is the one appearing in the image fits header, so I think that it is better to stick to the original name.

          Show
          boutigny Dominique Boutigny added a comment - Thanks Simon. Regarding the masks name starting with "test", I agree that it is a poor choice, unfortunately this is the "official" name from Elixir and it is the one appearing in the image fits header, so I think that it is better to stick to the original name.
          Hide
          krughoff Simon Krughoff added a comment -

          Fine by me. Merge away.

          Show
          krughoff Simon Krughoff added a comment - Fine by me. Merge away.

            People

            • Assignee:
              boutigny Dominique Boutigny
              Reporter:
              boutigny Dominique Boutigny
              Reviewers:
              Simon Krughoff
              Watchers:
              Dominique Boutigny, John Swinbank, Simon Krughoff
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel