Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10506

Run blendedness by default

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None
    • Story Points:
      0.1
    • Team:
      Data Release Production

      Description

      Jim Bosch wrote on DM-10350:

      It looks like we're not running the blendedness algorithm by default. Should just be a matter of adding base_Blendendness to measurement.plugins.names for at least SingleFrameMeasurementTask (I don't think running it on SFM and forced is useful, though that doesn't stop us in other contexts). Probably best to do that in meas_base, assuming that doesn't cause trouble anywhere.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Jim Bosch, please check that this implementation is what you expected.

            price@pap-laptop:~/LSST/meas_base (tickets/DM-10506=) $ git sub-patch
            commit 8fd86458dc7eeec12024e103b7beba0a5826e494
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Wed May 10 14:40:09 2017 -0400
             
                sfm: add blendedness plugin by default
                
                The blendedness is a useful quantity to have and it doesn't add
                much time, so we should calculate it by default.
             
            diff --git a/python/lsst/meas/base/sfm.py b/python/lsst/meas/base/sfm.py
            index b95daa1..7e87223 100644
            --- a/python/lsst/meas/base/sfm.py
            +++ b/python/lsst/meas/base/sfm.py
            @@ -130,6 +130,7 @@ class SingleFrameMeasurementConfig(BaseMeasurementConfig):
                              "base_CircularApertureFlux",
                              "base_SkyCoord",
                              "base_Variance",
            +                 "base_Blendedness",
                              ],
                     doc="Plugins to be run and their configuration"
                 )
            

            Show
            price Paul Price added a comment - Jim Bosch , please check that this implementation is what you expected. price@pap-laptop:~/LSST/meas_base (tickets/DM-10506=) $ git sub-patch commit 8fd86458dc7eeec12024e103b7beba0a5826e494 Author: Paul Price <price@astro.princeton.edu> Date: Wed May 10 14:40:09 2017 -0400   sfm: add blendedness plugin by default The blendedness is a useful quantity to have and it doesn't add much time, so we should calculate it by default.   diff --git a/python/lsst/meas/base/sfm.py b/python/lsst/meas/base/sfm.py index b95daa1..7e87223 100644 --- a/python/lsst/meas/base/sfm.py +++ b/python/lsst/meas/base/sfm.py @@ -130,6 +130,7 @@ class SingleFrameMeasurementConfig(BaseMeasurementConfig): "base_CircularApertureFlux", "base_SkyCoord", "base_Variance", + "base_Blendedness", ], doc="Plugins to be run and their configuration" )
            Hide
            jbosch Jim Bosch added a comment -

            Looks great, thanks!

            Show
            jbosch Jim Bosch added a comment - Looks great, thanks!
            Hide
            price Paul Price added a comment -
            Show
            price Paul Price added a comment - Jenkins passed .
            Hide
            price Paul Price added a comment -

            Merged to master.

            Show
            price Paul Price added a comment - Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Jim Bosch
                Watchers:
                Jim Bosch, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: