Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10518

Better manage jointcal test output directories

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Sprint:
      Alert Production S17 - 6, Alert Production F17 - 7, Alert Production F17 - 8
    • Team:
      Alert Production

      Description

      Jointcal currently doesn't manage its output repo directories in the best way. We should probably use something more like os.path.dirname(__file__) + '/.test' as the directory root (currently, .test ends up in the directory it was run from, which could be jointcal/ if run from e.g. scons), and also make sure scons cleans up that directory before a run. We don't want python/pytest to do the cleanup, as we don't want to delete output/plots when a user is running tests as part of development, but having scons do it should be fine.

        Attachments

          Activity

          No builds found.
          Parejkoj John Parejko created issue -
          Parejkoj John Parejko made changes -
          Field Original Value New Value
          Epic Link DM-9680 [ 30785 ]
          Parejkoj John Parejko made changes -
          Sprint Alert Production S17 - 6 [ 616 ]
          krughoff Simon Krughoff made changes -
          Sprint Alert Production S17 - 6 [ 616 ] Alert Production S17 - 6, Alert Production F17 - 7 [ 616, 626 ]
          krughoff Simon Krughoff made changes -
          Rank Ranked higher
          ebellm Eric Bellm made changes -
          Sprint Alert Production S17 - 6, Alert Production F17 - 7 [ 616, 626 ] Alert Production S17 - 6, Alert Production F17 - 7, Alert Production F17 - 8 [ 616, 626, 632 ]
          ebellm Eric Bellm made changes -
          Rank Ranked higher
          swinbank John Swinbank made changes -
          Description Jointcal currently doesn't manage its output repo directories in the best way. We should probably use something more like {{os.path.dirname(__file__) + '/.test'}} as the directory root (currently, {{.test}} ends up in the directory it was run from, which could be {{jointcal/}} if run from e.g. scons), and also make sure scons cleans up that directory before a run. We don't want python/pytest to do the cleanup, as we don't want to delete output/plots when a user is running tests as part of development, but having scons do it should be fine. Jointcal currently doesn't manage its output repo directories in the best way. We should probably use something more like {{os.path.dirname(\_\_file\_\_) + '/.test'}} as the directory root (currently, {{.test}} ends up in the directory it was run from, which could be {{jointcal/}} if run from e.g. scons), and also make sure scons cleans up that directory before a run. We don't want python/pytest to do the cleanup, as we don't want to delete output/plots when a user is running tests as part of development, but having scons do it should be fine.
          Hide
          swinbank John Swinbank added a comment -

          Hey folks, I note we've been carrying this for a few sprints now, but it's not actually got anybody assigned to work on it. Is the plan that somebody will pick it up spontaneously at a "tech debt day"? Sorry that I am naive in the AP group conventions about this.

          Show
          swinbank John Swinbank added a comment - Hey folks, I note we've been carrying this for a few sprints now, but it's not actually got anybody assigned to work on it. Is the plan that somebody will pick it up spontaneously at a "tech debt day"? Sorry that I am naive in the AP group conventions about this.
          Parejkoj John Parejko made changes -
          Assignee John Parejko [ parejkoj ]
          Hide
          Parejkoj John Parejko added a comment -

          No, you're not naive; either I forgot to assign it to me, or I shouldn't have added it to the sprint in May. That's long enough now that I have no idea which is which, and it's been dragging along through the sprints because I never saw it on the agile panel.

          I've just assigned it to me, and I guess I'll poke at it during some "free time", just to get rid of it.

          Show
          Parejkoj John Parejko added a comment - No, you're not naive; either I forgot to assign it to me, or I shouldn't have added it to the sprint in May. That's long enough now that I have no idea which is which, and it's been dragging along through the sprints because I never saw it on the agile panel. I've just assigned it to me, and I guess I'll poke at it during some "free time", just to get rid of it.
          swinbank John Swinbank made changes -
          Epic Link DM-9680 [ 30785 ] DM-10068 [ 31628 ]
          swinbank John Swinbank made changes -
          Sprint Alert Production S17 - 6, Alert Production F17 - 7, Alert Production F17 - 8 [ 616, 626, 632 ] Alert Production S17 - 6, Alert Production F17 - 7, Alert Production F17 - 8, Alert Production F17 - 9 [ 616, 626, 632, 639 ]
          swinbank John Swinbank made changes -
          Rank Ranked higher
          Parejkoj John Parejko made changes -
          Rank Ranked lower
          Parejkoj John Parejko made changes -
          Sprint Alert Production S17 - 6, Alert Production F17 - 7, Alert Production F17 - 8, Alert Production F17 - 9 [ 616, 626, 632, 639 ] Alert Production S17 - 6, Alert Production F17 - 7, Alert Production F17 - 8 [ 616, 626, 632 ]
          Parejkoj John Parejko made changes -
          Rank Ranked lower
          swinbank John Swinbank made changes -
          Epic Link DM-10068 [ 31628 ] DM-11798 [ 34281 ]
          swinbank John Swinbank made changes -
          Epic Link DM-11798 [ 34281 ] DM-12728 [ 36327 ]
          swinbank John Swinbank made changes -
          Epic Link DM-12728 [ 36327 ] DM-14447 [ 80385 ]
          Hide
          tjenness Tim Jenness added a comment -

          Is this ticket now obsoleted by DM-15513?

          Show
          tjenness Tim Jenness added a comment - Is this ticket now obsoleted by DM-15513 ?
          tjenness Tim Jenness made changes -
          Risk Score 0
          Hide
          Parejkoj John Parejko added a comment -

          Tim Jenness: no, that was just to fix an unrelated bug. This still should be done.

          Show
          Parejkoj John Parejko added a comment - Tim Jenness : no, that was just to fix an unrelated bug. This still should be done.
          swinbank John Swinbank made changes -
          Epic Link DM-14447 [ 80385 ] DM-16722 [ 235355 ]
          swinbank John Swinbank made changes -
          Epic Link DM-16722 [ 235355 ] DM-17887 [ 240317 ]
          swinbank John Swinbank made changes -
          Epic Link DM-17887 [ 240317 ] DM-19979 [ 307530 ]
          swinbank John Swinbank made changes -
          Epic Link DM-19979 [ 307530 ] DM-21441 [ 423048 ]
          swinbank John Swinbank made changes -
          Epic Link DM-21441 [ 423048 ] DM-22484 [ 427311 ]
          swinbank John Swinbank made changes -
          Epic Link DM-22484 [ 427311 ] DM-24339 [ 433026 ]
          swinbank John Swinbank made changes -
          Epic Link DM-24339 [ 433026 ] DM-25139 [ 435257 ]
          swinbank John Swinbank made changes -
          Epic Link DM-25139 [ 435257 ] DM-26810 [ 439762 ]
          sullivan Ian Sullivan made changes -
          Epic Link DM-26810 [ 439762 ] DM-27906 [ 442554 ]
          Parejkoj John Parejko made changes -
          Resolution Done [ 10000 ]
          Status To Do [ 10001 ] Invalid [ 11005 ]
          Hide
          Parejkoj John Parejko added a comment -

          Marking this invalid: I reworked the jointcal test output directories as part of gen3 jointcal, which took care of some of the problems on this ticket, while making others of them obsolete.

          Show
          Parejkoj John Parejko added a comment - Marking this invalid: I reworked the jointcal test output directories as part of gen3 jointcal, which took care of some of the problems on this ticket, while making others of them obsolete.

            People

            Assignee:
            Parejkoj John Parejko
            Reporter:
            Parejkoj John Parejko
            Watchers:
            John Parejko, John Swinbank, Simon Krughoff, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.