Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10522

Make dcrCoadds proper coadds

    Details

    • Story Points:
      3
    • Sprint:
      Alert Production S17 - 5
    • Team:
      Alert Production

      Description

      The dcrCoadd dataset type needs to be compatible with existing tools and functions that process coadds.

        Attachments

          Activity

          Hide
          yusra Yusra AlSayyad added a comment -

          Looks good.

          The project has some standards about shadowing builtins like "filter." Unfortunately for you, I fall in the camp that really doesn't like shadowing "filter". I liked your original filterName/filter_name variable name. It differentiates it from a integer filterId too.

          tests/testDcrTemplate.py lines 118 and 119: do you mean to leave this comment and line in? It's in a test, so I don't necessarily mind if you did.

          Commits could be squashed into a few.

          I assume these are eventually going to become Tasks and be renamed again?

          Show
          yusra Yusra AlSayyad added a comment - Looks good. The project has some standards about shadowing builtins like "filter." Unfortunately for you, I fall in the camp that really doesn't like shadowing "filter". I liked your original filterName/filter_name variable name. It differentiates it from a integer filterId too. History: https://jira.lsstcorp.org/browse/DM-831 --> https://developer.lsst.io/coding/python_style_guide.html#id31 tests/testDcrTemplate.py lines 118 and 119: do you mean to leave this comment and line in? It's in a test, so I don't necessarily mind if you did. Commits could be squashed into a few. I assume these are eventually going to become Tasks and be renamed again?
          Hide
          sullivan Ian Sullivan added a comment -

          Thanks for the review! I will change `filter` back to `filter_name`, as you suggest. You are correct that all of this code will be re-written soon as Tasks, and so some of the classes and methods will be re-named again at that point.

          Show
          sullivan Ian Sullivan added a comment - Thanks for the review! I will change `filter` back to `filter_name`, as you suggest. You are correct that all of this code will be re-written soon as Tasks, and so some of the classes and methods will be re-named again at that point.

            People

            • Assignee:
              sullivan Ian Sullivan
              Reporter:
              sullivan Ian Sullivan
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Ian Sullivan, Yusra AlSayyad
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: