XMLWordPrintable

## Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
3
• Sprint:
Alert Production S17 - 5
• Team:

## Description

The dcrCoadd dataset type needs to be compatible with existing tools and functions that process coadds.

## Activity

Hide

Looks good.

The project has some standards about shadowing builtins like "filter." Unfortunately for you, I fall in the camp that really doesn't like shadowing "filter". I liked your original filterName/filter_name variable name. It differentiates it from a integer filterId too.

tests/testDcrTemplate.py lines 118 and 119: do you mean to leave this comment and line in? It's in a test, so I don't necessarily mind if you did.

Commits could be squashed into a few.

I assume these are eventually going to become Tasks and be renamed again?

Show
Yusra AlSayyad added a comment - Looks good. The project has some standards about shadowing builtins like "filter." Unfortunately for you, I fall in the camp that really doesn't like shadowing "filter". I liked your original filterName/filter_name variable name. It differentiates it from a integer filterId too. History: https://jira.lsstcorp.org/browse/DM-831 --> https://developer.lsst.io/coding/python_style_guide.html#id31 tests/testDcrTemplate.py lines 118 and 119: do you mean to leave this comment and line in? It's in a test, so I don't necessarily mind if you did. Commits could be squashed into a few. I assume these are eventually going to become Tasks and be renamed again?
Hide
Ian Sullivan added a comment -

Thanks for the review! I will change filter back to filter_name, as you suggest. You are correct that all of this code will be re-written soon as Tasks, and so some of the classes and methods will be re-named again at that point.

Show
Ian Sullivan added a comment - Thanks for the review! I will change filter back to filter_name, as you suggest. You are correct that all of this code will be re-written soon as Tasks, and so some of the classes and methods will be re-named again at that point.

## People

• Assignee:
Ian Sullivan
Reporter:
Ian Sullivan
Reviewers: