# newinstall creates faulty loadLSST.csh file

XMLWordPrintable

#### Details

• Type: Bug
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s: None
• Labels:
None
• Story Points:
0.5
• Team:
SQuaRE

#### Description

If newinstall.sh is instructed to install miniconda, it adds miniconda python to the users path when calling loadLSST.csh, but the line added to the loadLSST.csh file has an additional parenthesis that makes the file invalid.

[ewok:~/lsst] lynnej% more loadLSST.csh

1. This script is intended to be used with (t)csh to load the minimal LSST
2. environment
3. Usage: source loadLSST.csh
1. Setup optional packages
setenv PATH /Users/lynnej/lsst/miniconda2-4.2.12/bin:$PATH) #### Attachments #### Issue Links #### Activity Hide Tim Jenness added a comment - I think that means we aren't really testing things on csh... Show Tim Jenness added a comment - I think that means we aren't really testing things on csh... Hide Joshua Hoblitt added a comment - Yes, travis is has only been testing bash. Show Joshua Hoblitt added a comment - Yes, travis is has only been testing bash. Hide Lynne Jones added a comment - Please check the EUPS_PKGROOT variable set by the loadLSST.csh script as well, I think this may also be being set incorrectly. [ljones@ops2 ~]$ source /lsst_stack3/loadLSST.csh
[ljones@ops2 ~]$env | grep EUPS EUPS_SHELL=csh EUPS_DIR=/lsst_stack3/eups EUPS_PATH=/lsst_stack3 SETUP_EUPS=eups LOCAL:/lsst_stack3/eups -f (none) -Z (none) [ljones@ops2 ~]$ eups distrib list sims_maf
eups distrib list: Please specify a repository with --server-dir or $EUPS_PKGROOT Show Lynne Jones added a comment - Please check the EUPS_PKGROOT variable set by the loadLSST.csh script as well, I think this may also be being set incorrectly. [ljones@ops2 ~]$ source /lsst_stack3/loadLSST.csh [ljones@ops2 ~] $env | grep EUPS EUPS_SHELL=csh EUPS_DIR=/lsst_stack3/eups EUPS_PATH=/lsst_stack3 SETUP_EUPS=eups LOCAL:/lsst_stack3/eups -f (none) -Z (none) [ljones@ops2 ~]$ eups distrib list sims_maf eups distrib list: Please specify a repository with --server-dir or $EUPS_PKGROOT Hide Joshua Hoblitt added a comment - Lynne Jones What version of csh/tcsh are you using? It seems that csh, when not being impersonated by tcsh, doesn't support$0 or any other native means to determine the path of the script being sourced. What I would like to do is state that we only "support" tcsh.

Show
Joshua Hoblitt added a comment - Lynne Jones What version of csh/tcsh are you using? It seems that csh , when not being impersonated by tcsh , doesn't support \$0 or any other native means to determine the path of the script being sourced. What I would like to do is state that we only "support" tcsh .
Hide
Joshua Hoblitt added a comment -

I've gone ahead and merged the PR which fixes tcsh. I'll mark this issue as resolved but we can reopen it if there is a genuine need to support pure csh.

Show
Joshua Hoblitt added a comment - I've gone ahead and merged the PR which fixes tcsh . I'll mark this issue as resolved but we can reopen it if there is a genuine need to support pure csh .

#### People

Assignee:
Joshua Hoblitt
Reporter:
Lynne Jones
Reviewers:
Tim Jenness
Watchers:
Joshua Hoblitt, Lynne Jones, Tim Jenness