Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10598

Include pixels flags in forced measurement

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None
    • Story Points:
      0.1
    • Team:
      Data Release Production

      Description

      Yoshihiko Yamada noticed that we aren't including pixel flags in the forced measurements, but they are very useful there especially since the centroids may be different from the unforced measurements.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Jim Bosch, would have have a look at this please?

            price@pap-laptop:~/LSST/meas_base (tickets/DM-10598=) $ git sub-patch
            commit decbf94f503032499827af0411012765b88a4aa8
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Wed May 24 10:03:24 2017 -0400
             
                forcedMeasurement: include pixel flags
                
                These are important to include on the forced measurement because
                the centroids can change from the unforced measurement.
             
            diff --git a/python/lsst/meas/base/forcedMeasurement.py b/python/lsst/meas/base/forcedMeasurement.py
            index c4500bc..36780a9 100644
            --- a/python/lsst/meas/base/forcedMeasurement.py
            +++ b/python/lsst/meas/base/forcedMeasurement.py
            @@ -146,7 +146,8 @@ class ForcedMeasurementConfig(BaseMeasurementConfig):
             
                 plugins = ForcedPlugin.registry.makeField(
                     multi=True,
            -        default=["base_TransformedCentroid",
            +        default=["base_PixelFlags",
            +                 "base_TransformedCentroid",
                              "base_TransformedShape",
                              "base_GaussianFlux",
                              "base_CircularApertureFlux",
            

            Show
            price Paul Price added a comment - Jim Bosch , would have have a look at this please? price@pap-laptop:~/LSST/meas_base (tickets/DM-10598=) $ git sub-patch commit decbf94f503032499827af0411012765b88a4aa8 Author: Paul Price <price@astro.princeton.edu> Date: Wed May 24 10:03:24 2017 -0400   forcedMeasurement: include pixel flags These are important to include on the forced measurement because the centroids can change from the unforced measurement.   diff --git a/python/lsst/meas/base/forcedMeasurement.py b/python/lsst/meas/base/forcedMeasurement.py index c4500bc..36780a9 100644 --- a/python/lsst/meas/base/forcedMeasurement.py +++ b/python/lsst/meas/base/forcedMeasurement.py @@ -146,7 +146,8 @@ class ForcedMeasurementConfig(BaseMeasurementConfig): plugins = ForcedPlugin.registry.makeField( multi=True, - default=["base_TransformedCentroid", + default=["base_PixelFlags", + "base_TransformedCentroid", "base_TransformedShape", "base_GaussianFlux", "base_CircularApertureFlux",
            Hide
            jbosch Jim Bosch added a comment -

            Looks good, thanks!

            Show
            jbosch Jim Bosch added a comment - Looks good, thanks!
            Hide
            price Paul Price added a comment -

            Thanks Jim.

            Merged to master.

            Show
            price Paul Price added a comment - Thanks Jim. Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Jim Bosch
                Watchers:
                Jim Bosch, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel