Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10600

Prototype designs at SuperTask hack week

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • wg-supertask
    • None
    • 10
    • DRP S17-6, DRP F17-1
    • Data Release Production

    Attachments

      Activity

        No builds found.
        jbosch Jim Bosch created issue -
        jbosch Jim Bosch made changes -
        Field Original Value New Value
        Epic Link DM-1109 [ 13916 ]
        jbosch Jim Bosch made changes -
        Status To Do [ 10001 ] In Progress [ 3 ]
        jbosch Jim Bosch added a comment - - edited

        This is my "tracking effort" ticket for the SuperTask WG hack week, but I think it makes sense to use it for the formal code review of the prototype in obs_base, where I spent the vast majority of my time last week. I've created a tickets/DM-10600 branch that's just a copy of u/jbosch/repodb-initial, so the existing PR can be used:

        https://github.com/lsst/obs_base/pull/45

        npease, I think it probably makes sense to ask you to do the formal review. Hopefully with the classes now documented it'll be easier to parse than it was last week. I'd also of course love comments from anyone else who has time to look, especially ktl, salnikov, gpdf, and price.

        It should be emphasized that this prototype is very incomplete. In addition to the concerns mentioned in the RepoDatabase design notes in the docs, all it really supports right now are skymap-based datasets, which are the simplest since they don't involve any per-camera specialization. I have ideas on how to extend it to camera-based datasets, and I hope to find time to prototype that out a bit more before handing this work entirely off to someone else, but I have other work that needs to take priority right now.

        jbosch Jim Bosch added a comment - - edited This is my "tracking effort" ticket for the SuperTask WG hack week, but I think it makes sense to use it for the formal code review of the prototype in obs_base, where I spent the vast majority of my time last week. I've created a tickets/ DM-10600 branch that's just a copy of u/jbosch/repodb-initial, so the existing PR can be used: https://github.com/lsst/obs_base/pull/45 npease , I think it probably makes sense to ask you to do the formal review. Hopefully with the classes now documented it'll be easier to parse than it was last week. I'd also of course love comments from anyone else who has time to look, especially ktl , salnikov , gpdf , and price . It should be emphasized that this prototype is very incomplete. In addition to the concerns mentioned in the RepoDatabase design notes in the docs, all it really supports right now are skymap-based datasets, which are the simplest since they don't involve any per-camera specialization. I have ideas on how to extend it to camera-based datasets, and I hope to find time to prototype that out a bit more before handing this work entirely off to someone else, but I have other work that needs to take priority right now.
        jbosch Jim Bosch made changes -
        Reviewers Nate Pease [ npease ]
        Status In Progress [ 3 ] In Review [ 10004 ]
        swinbank John Swinbank made changes -
        Epic Link DM-1109 [ 13916 ] DM-10586 [ 32520 ]
        swinbank John Swinbank made changes -
        Sprint DRP S17-6 [ 365 ] DRP S17-6, DRP F17-1 [ 365, 614 ]
        swinbank John Swinbank made changes -
        Rank Ranked higher
        jbosch Jim Bosch added a comment -

        npease, unless you've already put a lot of work into this review and are almost done, I think it might make it sense for me to relieve you of that duty and just merge this (to the supertaskdev branch, not master) as-is (well, maybe with some commit squashing). There's obviously a huge amount of broader and deeper review that would need to happen (let alone additional code) before this could ever go to master anyway.

        jbosch Jim Bosch added a comment - npease , unless you've already put a lot of work into this review and are almost done, I think it might make it sense for me to relieve you of that duty and just merge this (to the supertaskdev branch, not master) as-is (well, maybe with some commit squashing). There's obviously a huge amount of broader and deeper review that would need to happen (let alone additional code) before this could ever go to master anyway.

        jboschI think that's fine.

        npease Nate Pease [X] (Inactive) added a comment - jbosch I think that's fine.
        jbosch Jim Bosch added a comment -

        I've merged this to supertaskdev without squashing - I figure we'll have another opportunity to squash before supertaskdev is merged to master, and we'll be in at least as good a position to do that then as I am now (since it's now been a while since I last worked on the code).

        jbosch Jim Bosch added a comment - I've merged this to supertaskdev without squashing - I figure we'll have another opportunity to squash before supertaskdev is merged to master, and we'll be in at least as good a position to do that then as I am now (since it's now been a while since I last worked on the code).
        jbosch Jim Bosch made changes -
        Resolution Done [ 10000 ]
        Status In Review [ 10004 ] Done [ 10002 ]

        People

          jbosch Jim Bosch
          jbosch Jim Bosch
          Nate Pease [X] (Inactive)
          Jim Bosch, Nate Pease [X] (Inactive)
          Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved:

            Jenkins

              No builds found.