Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10604

PIPE_TASKS: change calls to lsst.afw.display.ds9 to use generic getDisplay

    Details

    • Type: Story
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Story Points:
      3
    • Sprint:
      DRP F17-1, DRP F17-2, DRP F17-3, DRP F17-4, DRP F17-5, DRP F17-6, DRP S18-1, DRP S18-2, DRP S18-3, DRP S18-4, DRP S18-5, DRP S18-6, DRP F18-1, DRP F18-2
    • Team:
      Data Release Production

      Description

      As in DM-9517, many calls to display with DS9 use the old ds9 specific interface.
      Change to use the registered display interface, and test to be sure each of the modules displays correctly when its display variables are set to True in debug.py.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Thanks Michael!

            Show
            swinbank John Swinbank added a comment - Thanks Michael!
            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            The code changes look fine.
            Rebase to current master first.
            (sorry for the extensive delay in reviewing this).

            I've spent 3 hours trying to get the display itself tested, but have been unable to do so. DM-11125 is one of symptoms.

            I suggest the best way forward at this point is to merge this.

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - The code changes look fine. Rebase to current master first. (sorry for the extensive delay in reviewing this). I've spent 3 hours trying to get the display itself tested, but have been unable to do so. DM-11125 is one of symptoms. I suggest the best way forward at this point is to merge this.
            Hide
            pgee Perry Gee added a comment -

            Michael Wood-Vasey

            I've been off a lot of the summer, but I see that you responded on this review. Thanks for getting to it.

            Are you not able to actually see the display in ds9 to test that the code is really working?

            Show
            pgee Perry Gee added a comment - Michael Wood-Vasey I've been off a lot of the summer, but I see that you responded on this review. Thanks for getting to it. Are you not able to actually see the display in ds9 to test that the code is really working?
            Hide
            lauren Lauren MacArthur added a comment -

            John Swinbank, while I would never claim to have caught all instances (only being able to search master on GitHub was particularly frustrating in this endeavour!), I think the bulk of this has been completed on DM-13432.

            Show
            lauren Lauren MacArthur added a comment - John Swinbank , while I would never claim to have caught all instances (only being able to search master on GitHub was particularly frustrating in this endeavour!), I think the bulk of this has been completed on DM-13432 .
            Hide
            swinbank John Swinbank added a comment -

            Thanks Lauren MacArthur. I think at this point we should just close this down.

            Show
            swinbank John Swinbank added a comment - Thanks Lauren MacArthur . I think at this point we should just close this down.

              People

              • Assignee:
                pgee Perry Gee
                Reporter:
                pgee Perry Gee
                Reviewers:
                Michael Wood-Vasey
                Watchers:
                John Swinbank, Lauren MacArthur, Michael Wood-Vasey, Perry Gee
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: