Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10621

ArgumentParser's butler doesn't output calibs in the calib storage

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_base
    • Labels:
      None
    • Story Points:
      1
    • Team:
      Data Release Production

      Description

      Following DM-8686 (between tagged weeklies w_2017_11 and w_2017_12), the constructBias.py (etc.) scripts in pipe_drivers write their outputs in the output storage rather than in the calib storage (e.g., /tigress/pprice/ci_hsc/DATA/rerun/ci_hsc/BIAS/2017-12-34/NONE/BIAS-2017-12-34-012.fits instead of /tigress/pprice/ci_hsc/DATA/rerun/ci_hsc/CALIB/BIAS/2017-12-34/NONE/BIAS-2017-12-34-012.fits).

      This appears to be due to the output repo being unaware of calibs because it's not being told about them by the ArgumentParser in pipe_base.

      This was originally reported by Furusawa-san at NAOJ.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Nate Pease, would you mind reviewing this simple change to ensure it makes sense, butler-wise?

            price@pap-laptop:~/LSST/pipe_base (tickets/DM-10621=) $ git sub
            commit 2e047db8e1e5cca6499b2172764655dbb52ec6a7
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Thu May 25 13:59:44 2017 -0400
             
                ArgumentParser: add calibRoot to output mapperArgs
                
                Otherwise, the output repo doesn't know about the calib storage and
                writes calibs in the output storage rather than the calib storage.
             
             python/lsst/pipe/base/argumentParser.py | 10 ++++++----
             1 file changed, 6 insertions(+), 4 deletions(-)
            

            Show
            price Paul Price added a comment - Nate Pease , would you mind reviewing this simple change to ensure it makes sense, butler-wise? price@pap-laptop:~/LSST/pipe_base (tickets/DM-10621=) $ git sub commit 2e047db8e1e5cca6499b2172764655dbb52ec6a7 Author: Paul Price <price@astro.princeton.edu> Date: Thu May 25 13:59:44 2017 -0400   ArgumentParser: add calibRoot to output mapperArgs Otherwise, the output repo doesn't know about the calib storage and writes calibs in the output storage rather than the calib storage.   python/lsst/pipe/base/argumentParser.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
            Hide
            npease Nate Pease added a comment -

            looks good.

            Show
            npease Nate Pease added a comment - looks good.
            Hide
            price Paul Price added a comment -

            Thanks Nate!

            Merged to master.

            Show
            price Paul Price added a comment - Thanks Nate! Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Nate Pease
                Watchers:
                Nate Pease, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: