Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10634

Check configs for coaddDriver

    XMLWordPrintable

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None
    • Team:
      Data Release Production

      Description

      Nate Lust points out that the configs for coaddDriver in obs_subaru don't include detection, and I think that means they're using the default sky subtraction, when they should just be subtracting a single value per patch.

      Investigate, and clean up.

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          On DM-11243, Lauren MacArthur points out that some elements that are being read in don't exist, and we need to respect the difference between `assembleCoadd` and `safeClipAssembleCoadd`.

          Show
          price Paul Price added a comment - On DM-11243 , Lauren MacArthur points out that some elements that are being read in don't exist, and we need to respect the difference between `assembleCoadd` and `safeClipAssembleCoadd`.
          Hide
          yusra Yusra AlSayyad added a comment -

          In response to Lauren MacArthur's comment on DM-11243: I decided that assembleCoadd.py should ---> SafeClipAssmebleCoadd.py and DM-13410 had a commit https://github.com/lsst/obs_subaru/commit/e3807df311f3d071f07f91d60a5e8957e0a2ee5d that made safeClip's override file read in assemble's file so that any additional configs added to that file are a delta on assemble's. People were forgetting that if they wanted to change the coaddition configs they needed to change it in 3 files. Previously, config/coaddDriver.py also was reading in config/assembleCoadd.py when it ran safeClip, and so the only reason it worked was because the configs overrides were identical!

          Speaking of code duplication... do we really need config/hsc to contain exact copies of config/? I've been putting changes to the default coaddition configs in config/ rather than config/hsc.

          Show
          yusra Yusra AlSayyad added a comment - In response to Lauren MacArthur 's comment on DM-11243 : I decided that assembleCoadd.py should ---> SafeClipAssmebleCoadd.py and DM-13410 had a commit https://github.com/lsst/obs_subaru/commit/e3807df311f3d071f07f91d60a5e8957e0a2ee5d that made safeClip's override file read in assemble's file so that any additional configs added to that file are a delta on assemble's. People were forgetting that if they wanted to change the coaddition configs they needed to change it in 3 files. Previously, config/coaddDriver.py also was reading in config/assembleCoadd.py when it ran safeClip, and so the only reason it worked was because the configs overrides were identical! Speaking of code duplication... do we really need config/hsc to contain exact copies of config/ ? I've been putting changes to the default coaddition configs in config/ rather than config/hsc .

            People

            Assignee:
            price Paul Price
            Reporter:
            price Paul Price
            Watchers:
            Hsin-Fang Chiang, Paul Price, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated: