Details
-
Type:
Story
-
Status: Won't Fix
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_subaru
-
Labels:None
-
Team:Data Release Production
Description
Nate Lust points out that the configs for coaddDriver in obs_subaru don't include detection, and I think that means they're using the default sky subtraction, when they should just be subtracting a single value per patch.
Investigate, and clean up.
Attachments
Issue Links
- mentioned in
-
Page Loading...
Activity
In response to Lauren MacArthur's comment on DM-11243: I decided that assembleCoadd.py should ---> SafeClipAssmebleCoadd.py and DM-13410 had a commit https://github.com/lsst/obs_subaru/commit/e3807df311f3d071f07f91d60a5e8957e0a2ee5d that made safeClip's override file read in assemble's file so that any additional configs added to that file are a delta on assemble's. People were forgetting that if they wanted to change the coaddition configs they needed to change it in 3 files. Previously, config/coaddDriver.py also was reading in config/assembleCoadd.py when it ran safeClip, and so the only reason it worked was because the configs overrides were identical!
Speaking of code duplication... do we really need config/hsc to contain exact copies of config/? I've been putting changes to the default coaddition configs in config/ rather than config/hsc.
Calling Won't Fix as both a Gen2 problem and an algorithm subject that's had intentional behavior changes a few times since this was created.
On
DM-11243, Lauren MacArthur points out that some elements that are being read in don't exist, and we need to respect the difference between `assembleCoadd` and `safeClipAssembleCoadd`.