Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_base
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:Measurement-S14-4
-
Team:Data Release Production
Description
We should move the code in the algorithms subdirectory (and namespace) into the .cc files that correspond to individual algorithms. They should generally go into anonymous namespaces there.
After doing so, we should do one more test to compare the meas_base and meas_algorithms implementations.
Attachments
Activity
This appears to have been merged to master?
Paul Price
added a comment - This appears to have been merged to master? Yes. Jim says that I missed something in the process. He has always
supplied change requests on the issue comments, as has Yusra. If I missed
requested changes, I will put then on a second ticket tomorrow.
Until we move to GitHub, a summary of the review comments should be entered into JIRA. GitHub pull request comments are not (yet) official, but developers should know how to look at them and should deal with them before merging to master.
The last comment on this issue was from me, not Robyn. I checked in the responses to the review comments about a month ago, I believe.
Perry Gee
added a comment - The last comment on this issue was from me, not Robyn. I checked in the responses to the review comments about a month ago, I believe. 
It's not the ticket, it's the commits.