Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1067

move algorithm implementations out of separate subdirectory

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:

      Description

      We should move the code in the algorithms subdirectory (and namespace) into the .cc files that correspond to individual algorithms. They should generally go into anonymous namespaces there.

      After doing so, we should do one more test to compare the meas_base and meas_algorithms implementations.

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          It's not the ticket, it's the commits.

          Show
          price Paul Price added a comment - It's not the ticket, it's the commits.
          Hide
          price Paul Price added a comment -

          This appears to have been merged to master?

          Show
          price Paul Price added a comment - This appears to have been merged to master?
          Hide
          robyn Robyn Allsman [X] (Inactive) added a comment -

          Yes. Jim says that I missed something in the process. He has always
          supplied change requests on the issue comments, as has Yusra. If I missed
          requested changes, I will put then on a second ticket tomorrow.

          Show
          robyn Robyn Allsman [X] (Inactive) added a comment - Yes. Jim says that I missed something in the process. He has always supplied change requests on the issue comments, as has Yusra. If I missed requested changes, I will put then on a second ticket tomorrow.
          Hide
          ktl Kian-Tat Lim added a comment -

          Until we move to GitHub, a summary of the review comments should be entered into JIRA. GitHub pull request comments are not (yet) official, but developers should know how to look at them and should deal with them before merging to master.

          Show
          ktl Kian-Tat Lim added a comment - Until we move to GitHub, a summary of the review comments should be entered into JIRA. GitHub pull request comments are not (yet) official, but developers should know how to look at them and should deal with them before merging to master.
          Hide
          pgee Perry Gee added a comment -

          The last comment on this issue was from me, not Robyn. I checked in the responses to the review comments about a month ago, I believe.

          Show
          pgee Perry Gee added a comment - The last comment on this issue was from me, not Robyn. I checked in the responses to the review comments about a month ago, I believe.

            People

            Assignee:
            pgee Perry Gee
            Reporter:
            jbosch Jim Bosch
            Reviewers:
            Paul Price
            Watchers:
            Jim Bosch, Kian-Tat Lim, Paul Price, Perry Gee, Robyn Allsman [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.