Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1070

switch default table version to 1

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:

      Description

      Now that all tasks that use catalogs explicitly set the table version, it should be relatively straightforward to set the default version to 1 in afw. Code that cannot handle version > 0 tables should continue to explicitly set version=0.

        Attachments

          Activity

          Hide
          pgee Perry Gee added a comment -

          Moved DEFAULT_VERSION to SchemaImpl, but kept a reference to in in Schema. This is because SchemaImpl is not visible from Python, and it seems like it would be ugly to make it so.

          Only module really changed in AFW_DIR. Here are the changes:

          emerald:/sandbox/lsstshared/pgee/mylsst7/Linux64/afw> git diff tickets/DM-590 --stat
          include/lsst/afw/table/Schema.h | 4 +++-
          include/lsst/afw/table/detail/SchemaImpl.h | 2 ++
          tests/testFunctorKeys.py | 3 +++
          tests/testSchema.py | 1 +
          tests/testSimpleTable.py | 1 +
          5 files changed, 10 insertions, 1 deletion
          -----------------------------------------------------------

          Unit tests have been run in afw, meas_algorithms, meas_base, meas_astrom, meas_deblender, pipe_tasks. Changes to a few unit tests were required to call schema.setVersion(0)

          No changes required to meas_base, ip_diffim
          These are checked in to tickets/DM-1070 for those packages

          ----------------------------------oops, just discovered a unit test failure in ap. Will fix it as soon as I get home.

          Show
          pgee Perry Gee added a comment - Moved DEFAULT_VERSION to SchemaImpl, but kept a reference to in in Schema. This is because SchemaImpl is not visible from Python, and it seems like it would be ugly to make it so. Only module really changed in AFW_DIR. Here are the changes: emerald:/sandbox/lsstshared/pgee/mylsst7/Linux64/afw> git diff tickets/ DM-590 --stat include/lsst/afw/table/Schema.h | 4 +++- include/lsst/afw/table/detail/SchemaImpl.h | 2 ++ tests/testFunctorKeys.py | 3 +++ tests/testSchema.py | 1 + tests/testSimpleTable.py | 1 + 5 files changed, 10 insertions , 1 deletion ----------------------------------------------------------- Unit tests have been run in afw, meas_algorithms, meas_base, meas_astrom, meas_deblender, pipe_tasks. Changes to a few unit tests were required to call schema.setVersion(0) No changes required to meas_base, ip_diffim These are checked in to tickets/ DM-1070 for those packages ----------------------------------oops, just discovered a unit test failure in ap. Will fix it as soon as I get home.
          Hide
          pgee Perry Gee added a comment -

          Problem with ap fixed in branch tickets/DM-1070. Just more setVersion(0) calls.

          Code now ready to review.

          Show
          pgee Perry Gee added a comment - Problem with ap fixed in branch tickets/ DM-1070 . Just more setVersion(0) calls. Code now ready to review.
          Hide
          jbosch Jim Bosch added a comment -

          I don't see a tickets/DM-1070 or u/pgee/DM-1070 branch for afw. Did you forget to push?

          Show
          jbosch Jim Bosch added a comment - I don't see a tickets/ DM-1070 or u/pgee/ DM-1070 branch for afw. Did you forget to push?
          Hide
          jbosch Jim Bosch added a comment -

          All changes look fine, including those from DM-590.

          I don't personally care about having Schema::DEFAULT_VERSION visible to Swig, and I'd be just as happy to remove it, but if you find it useful for unit test purposes I'm fine with leaving it in.

          Show
          jbosch Jim Bosch added a comment - All changes look fine, including those from DM-590 . I don't personally care about having Schema::DEFAULT_VERSION visible to Swig, and I'd be just as happy to remove it, but if you find it useful for unit test purposes I'm fine with leaving it in.

            People

            Assignee:
            pgee Perry Gee
            Reporter:
            jbosch Jim Bosch
            Reviewers:
            Jim Bosch
            Watchers:
            Jim Bosch, Perry Gee
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.