Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_diffim, lsst_dm_stack_demo, obs_sdss, pipe_tasks
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:Measurement-S14-4
-
Team:Data Release Production
Description
We should set the default measurement task in ProcessImageTask to SingleFrameMeasurementTask, and note that SourceMeasurementTask and the old forced photometry drivers are deprecated.
Attachments
Issue Links
- relates to
-
DM-3213 Get ImageDifferenceTask running again
- Done
A quibble: I'd like consistently just use lsst.meas.base.SingleFrameMeasurementTask rather than lsst.meas.base.sfm.SingleFrameMeasurementTask, since lsst/meas/base/__init__.py does from .sfm import * (and the same for all the other submodules of lsst.meas.base). While we don't have an official policy on this one way or the other, IMO including the submodule is unnecessarily verbose and slightly more fragile.
If you're comfortable doing so, please consider using git rebase -i to squash the obs_sdss fixup commits into the commits that they fix.
I think it would be fine to switch to version=1 in forcedPhot.py, but I'm not sure we need to. The larger problem here is that the ReferencesTask is not compatible with the new BaseReferencesTask API in meas_base, so at present it can only be used with the old forcedPhot.py task in pipe_tasks, which will eventually go away. I'm not convinced we need the special SDSS override for references - our CoaddSrcReferenceTask would work fine for SDSS, and I think it's probably better in that it doesn't rely on the database. We should capture that extra work on a new issue, and talk about the best way to resolve it with others.