Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10738

Increasing radius on sky causes matching to fail.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_astrom
    • Labels:
      None
    • Team:
      Alert Production

      Description

      Before this commit there was a bug in the reference star selector, which meant it didn't actually retrieve stars over the area specified.

      Now that is fixed, having a large value for config.calibrate.astrometry.matcher.maxOffsetPix can cause the matcher to fail to match in situations in which it succeeds when a smaller value is used.

      Please note that the commit referenced above is not causing this problem, but is fixing a bug which then allows the fragility of the underlying matching algorithm to be seen.

      This is thought to be a general problem; I have seen this on obs_ctio0m9 data, and Chris Morrison [X] has seen this on DECam data.

        Attachments

          Issue Links

            Activity

            Hide
            krughoff Simon Krughoff added a comment -

            I don't think this is worth putting much effort into fixing since it is already fixed when using Chris' new matcher. My suggestion is that we try to merge that as soon as possible.

            Show
            krughoff Simon Krughoff added a comment - I don't think this is worth putting much effort into fixing since it is already fixed when using Chris' new matcher. My suggestion is that we try to merge that as soon as possible.
            Hide
            tjenness Tim Jenness added a comment -

            Given Simon Krughoff's comment can we close this ticket now (4 years later) as won't fix?

            Show
            tjenness Tim Jenness added a comment - Given Simon Krughoff 's comment can we close this ticket now (4 years later) as won't fix?
            Hide
            jbosch Jim Bosch added a comment -

            Closing as Won't Fix for reasons stated in previous comments.

            Show
            jbosch Jim Bosch added a comment - Closing as Won't Fix for reasons stated in previous comments.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            Sorry for being slow here, just confirming that's fine, I don't see this behaviour in the new matcher.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Sorry for being slow here, just confirming that's fine, I don't see this behaviour in the new matcher.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              mfisherlevine Merlin Fisher-Levine
              Watchers:
              Chris Morrison [X] (Inactive), Jim Bosch, Merlin Fisher-Levine, Robert Lupton, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.