Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: base, ci_hsc, ctrl_pool, meas_base, meas_deblender, meas_extensions_psfex, meas_mosaic, obs_decam, obs_subaru, pipe_base, pipe_drivers, pipe_tasks, shapelet, skymap
-
Labels:None
-
Team:Data Release Production
Description
Furusawa-san points out that "pipe_drivers" isn't in the packages provenance list. I believe this is because the __init__.py doesn't from .versions import *, so there's no version information to grab.
I should survey other packages as well, and/or make a workaround in the code that saves the versions.
Attachments
Issue Links
- blocks
-
- Done
Activity
I added a test in ci_hsc to ensure the versions are getting set, and it's gone through successfully.
Paul Price
added a comment - I added a test in ci_hsc to ensure the versions are getting set, and it's gone through successfully . Thanks for agreeing to review this, Chris Morrison [X]. I hope it won't be a problem: despite the large number of packages, the changes are generally fairly simple.
Paul Price
added a comment - Thanks for agreeing to review this, Chris Morrison [X] . I hope it won't be a problem: despite the large number of packages, the changes are generally fairly simple. Hi Paul,
I've "thumbs'ed up" most of the changes as they were, like you said fairly straight forward. On the base and pipe_base packages could you provide me a few comments as to the context of what you are doing in these two packages? You made a comment above as to what is going on with ci_hsc and it would be helpful for me to get a little more understanding of what is being done with base and pipe_base and how it relates to this ticket. It seems to be more involved than just adding version information.
Also your pull request on base doesn't have the ticket number in the title of the request.
I've fixed the base PR title.
A bit more explanation:
- base: The Packages class has a dict of packages (mapping package name to version). For testing, it's convenient to be able to iterate through the elements of Packages and to ask if a particular package is in the Packages, so I've added __contains__ and __iter__ methods to Packages that redirect to the dict that it holds.
- pipe_base: This looks straightforward; did you mean a different package? Oh, I see pipe_tasks has some more stuff, so I'll assume you meant that.
- pipe_tasks: This has the usual import addition, and I took the opportunity to add a file to .gitignore that's been bugging me for a while. But the more interesting change is to makeSkyMap.py, which wasn't persisting version information. That's because the MakeSkyMapRunner.precall was disabled, in order that it wouldn't persist the config or metadata. I changed that so that it now uses the standard way of disabling the config and metadata, which means that the standard precall fires, which checks and persists the version information (and I know it does because skymap is checked in ci_hsc).
Paul Price
added a comment - I've fixed the base PR title.
A bit more explanation:
base : The Packages class has a dict of packages (mapping package name to version). For testing, it's convenient to be able to iterate through the elements of Packages and to ask if a particular package is in the Packages , so I've added __contains__ and __iter__ methods to Packages that redirect to the dict that it holds.
pipe_base : This looks straightforward; did you mean a different package? Oh, I see pipe_tasks has some more stuff, so I'll assume you meant that.
pipe_tasks : This has the usual import addition, and I took the opportunity to add a file to .gitignore that's been bugging me for a while. But the more interesting change is to makeSkyMap.py , which wasn't persisting version information. That's because the MakeSkyMapRunner.precall was disabled, in order that it wouldn't persist the config or metadata. I changed that so that it now uses the standard way of disabling the config and metadata, which means that the standard precall fires, which checks and persists the version information (and I know it does because skymap is checked in ci_hsc ).
Yeah, I meant pipe_tasks. Okay, that seems fairly straight forward. Assuming it passes Jenkins then things should be good to go.
Finished review. No significant changes needed.
Thanks Chris.
Merged to master.
Paul Price
added a comment - Thanks Chris.
Merged to master. 
Found several packages with the missing important line.