Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10765

Replace existing WCS classes with SkyWcs

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      27
    • Epic Link:
    • Sprint:
      Alert Production S17 - 6, Alert Production F17 - 7, Alert Production F17 - 8, Alert Production F17 - 9, Alert Production F17 - 10, Alert Production F17 - 11, AP S18-1, AP S18-2, AP S18-3
    • Team:
      Alert Production

      Description

      Replace all use of lsst.afw.image.Wcs and subclasses with lsst.afw.geom.SkyWcs in the DM stack.

      This will also require replacing much of our use of XYTransform with TransformPoint2ToPoint2

      The changes are described in this community post: Replacing Wcs and TanWcs with SkyWcs

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            Thank you: I continue to be happy.

            Show
            Parejkoj John Parejko added a comment - Thank you: I continue to be happy.
            Hide
            rearmstr Bob Armstrong added a comment -

            I've looked over my assigned packages and made some minor comments on github. Looks good!

            Show
            rearmstr Bob Armstrong added a comment - I've looked over my assigned packages and made some minor comments on github. Looks good!
            Hide
            rearmstr Bob Armstrong added a comment -

            I prematurely marked this as reviewed. It is still waiting on Josh.

            Show
            rearmstr Bob Armstrong added a comment - I prematurely marked this as reviewed. It is still waiting on Josh.
            Hide
            jmeyers314 Joshua Meyers added a comment - - edited

            Looks good.  I had a few small comments (on GitHub) on my assigned packages.

            Show
            jmeyers314 Joshua Meyers added a comment - - edited Looks good.  I had a few small comments (on GitHub) on my assigned packages.
            Hide
            lauren Lauren MacArthur added a comment -

            Ok, I'm done.  Mostly looks good, but see my comments on the PRs (and note that I ignored PR #97 as it seems to belong to another ticket).  I am assuming there will be thorough testing (Jenkins and a RC reduction run, I hear) before this is merged.

            Show
            lauren Lauren MacArthur added a comment - Ok, I'm done.  Mostly looks good, but see my comments on the PRs (and note that I ignored PR #97 as it seems to belong to another ticket).  I am assuming there will be thorough testing (Jenkins and a RC reduction run, I hear) before this is merged.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Bob Armstrong, Joshua Meyers, Lauren MacArthur
                Watchers:
                Bob Armstrong, Jim Bosch, John Parejko, Joshua Meyers, Lauren MacArthur, Russell Owen, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel