Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10776

Make Formatter and Storage type-safe

    XMLWordPrintable

    Details

      Description

      The implementations of daf::persistence::Formatter::read and Formatter::write in afw accept a Storage and then use RTTI to choose actions depending on the implementation class of Storage. While I've cleaned up the code slightly as part of DM-10257, it ought to be replaced with something based on virtual methods and/or templates instead of RTTI. This will require API changes in daf_persistence.

        Attachments

          Activity

          Hide
          tjenness Tim Jenness added a comment - - edited

          John Swinbank Does the presence of this ticket in an F20 epic mean we might attempt to do it? 6SP seems a lot of effort for a daf_persistence cleanup given the imminent gen2 deprecation.

          Show
          tjenness Tim Jenness added a comment - - edited John Swinbank Does the presence of this ticket in an F20 epic mean we might attempt to do it? 6SP seems a lot of effort for a daf_persistence cleanup given the imminent gen2 deprecation.
          Hide
          krzys Krzysztof Findeisen added a comment -

          John Swinbank may have other plans, but from the issue history it looks like the issue was added to emergent epics by default rather than out of a specific commitment to do it. I would certainly be happy with this issue becoming obsolete.

          Show
          krzys Krzysztof Findeisen added a comment - John Swinbank may have other plans, but from the issue history it looks like the issue was added to emergent epics by default rather than out of a specific commitment to do it. I would certainly be happy with this issue becoming obsolete.
          Hide
          swinbank John Swinbank added a comment -

          If this issue is obsolete in Gen3, please go ahead and close it as “Won't Fix”.

          Show
          swinbank John Swinbank added a comment - If this issue is obsolete in Gen3, please go ahead and close it as “Won't Fix”.
          Hide
          tjenness Tim Jenness added a comment -

          Gen3 has a completely different implementation of storage classes and formatters so closing this as won't fix.

          Show
          tjenness Tim Jenness added a comment - Gen3 has a completely different implementation of storage classes and formatters so closing this as won't fix.

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            krzys Krzysztof Findeisen
            Watchers:
            John Swinbank, Krzysztof Findeisen, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.