Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ci_hsc
-
Labels:None
-
Story Points:1
-
Team:Data Release Production
Description
We're running production with bright star masks, so those should also be in the integration test. Otherwise there's the possibility that production fails when ci_hsc passes.
Attachments
Issue Links
Activity
This seems like it's opening a bigger potentially QA-related can of worms of "how to tell if a run is successful."
Aha! I was putting the bright object mask files in the wrong place, they weren't being found and it was skipping over that error as if there were no bright object masks to apply.
I've fixed up the installation of the masks and added a check in the ci_hsc validation to ensure that the masks are actually applied. Jenkins passes.
Paul Price
added a comment - Aha! I was putting the bright object mask files in the wrong place, they weren't being found and it was skipping over that error as if there were no bright object masks to apply.
I've fixed up the installation of the masks and added a check in the ci_hsc validation to ensure that the masks are actually applied. Jenkins passes . OK, this looks good-- and if jenkins passes, that's the test we need. The validation check looks like it's checking the right thing.
Thanks Tim.
Merged to master.
Paul Price
added a comment - Thanks Tim.
Merged to master. 
Even with --doraise coadd won't actually die, btw.