Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10782

Add bright star masks to ci_hsc

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ci_hsc
    • Labels:
      None
    • Story Points:
      1
    • Team:
      Data Release Production

      Description

      We're running production with bright star masks, so those should also be in the integration test. Otherwise there's the possibility that production fails when ci_hsc passes.

        Attachments

          Issue Links

            Activity

            Hide
            tmorton Tim Morton added a comment -

            Even with --doraise coadd won't actually die, btw.

            Show
            tmorton Tim Morton added a comment - Even with --doraise coadd won't actually die, btw.
            Hide
            tmorton Tim Morton added a comment -

            This seems like it's opening a bigger potentially QA-related can of worms of "how to tell if a run is successful."

            Show
            tmorton Tim Morton added a comment - This seems like it's opening a bigger potentially QA-related can of worms of "how to tell if a run is successful."
            Hide
            price Paul Price added a comment -

            Aha! I was putting the bright object mask files in the wrong place, they weren't being found and it was skipping over that error as if there were no bright object masks to apply.

            I've fixed up the installation of the masks and added a check in the ci_hsc validation to ensure that the masks are actually applied. Jenkins passes.

            Show
            price Paul Price added a comment - Aha! I was putting the bright object mask files in the wrong place, they weren't being found and it was skipping over that error as if there were no bright object masks to apply. I've fixed up the installation of the masks and added a check in the ci_hsc validation to ensure that the masks are actually applied. Jenkins passes .
            Hide
            tmorton Tim Morton added a comment -

            OK, this looks good-- and if jenkins passes, that's the test we need. The validation check looks like it's checking the right thing.

            Show
            tmorton Tim Morton added a comment - OK, this looks good-- and if jenkins passes, that's the test we need. The validation check looks like it's checking the right thing.
            Hide
            price Paul Price added a comment -

            Thanks Tim.

            Merged to master.

            Show
            price Paul Price added a comment - Thanks Tim. Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Tim Morton
                Watchers:
                Paul Price, Tim Morton
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel